This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
Fix generator to accomodate array types #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-collier
approved these changes
Apr 24, 2018
|
I don't understand what exactly this is adding to the generated MAPs data. I do see evidence that maybe we should revisit the regenerate data upon deploy question again since a lot of the generated MAP changes are just from not running this often with PRs that effect the MAPs. |
cmharlow
approved these changes
Apr 25, 2018
|
@cmh2166 it's not adding anything, it's just allowing the generator to work, which it doesn't do on master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go generatehas been broken since #400 was merged. it was unable to handle: