Allow barcode to be cleared out #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
allow-nil-barcode
branch
2 times, most recently
from
15eafe9
to
f837646
Compare
|
I just tested this again and got a weird error after saving I'm pretty sure I was able to clear a barcode last week so I'm not sure if this is related to the current stage deployments rather than the code. |
|
@andrewjbtw this PR is not deployed anywhere, so it is not testable |
jcoyne
force-pushed
the
allow-nil-barcode
branch
from
f837646
to
77f3d21
Compare
aaron-collier
approved these changes
Feb 8, 2022
|
Ah, ok. Then I'll ignore the error for now. |
jcoyne
force-pushed
the
allow-nil-barcode
branch
2 times, most recently
from
43cfc2f
to
ece84f3
Compare
jcoyne
commented
Feb 9, 2022
| @@ -16,7 +16,7 @@ def initialize(model, change_set) | |||
|
|
|||
| def update | |||
| updated = model | |||
| updated = update_identification(updated) if changed?(:source_id) || changed?(:catkey) || changed?(:barcode) | |||
| updated = update_identification(updated) if changed?(:source_id) || changed?(:catkey) | |||
There was a problem hiding this comment.
collections don't have barcode
|
Currently our openapi.yaml isn't going to support |
jcoyne
force-pushed
the
allow-nil-barcode
branch
from
ece84f3
to
490b0d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Fixes #3065
How was this change tested?
Which documentation and/or configurations were updated?