Only get id once. #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Nov 15, 2023
| @@ -33,6 +31,10 @@ def qfacet_selected? | |||
| config = helpers.facet_configuration_for_field(field_name) | |||
| helpers.search_state.filter(config).include?(item.qvalue) | |||
| end | |||
|
|
|||
| def ul_id | |||
| @ul_id ||= "b-h-#{SecureRandom.alphanumeric(10)}" | |||
There was a problem hiding this comment.
Where was this called more than one time?
There was a problem hiding this comment.
ul_id is used in L2 and L12 of app/components/blacklight/hierarchy/facet_field_component.html.erb
Previously, SecureRandom.alphanumeric(10) was called in facet_field_component.html.erb and facet_field_component.rb
jcoyne
approved these changes
Nov 15, 2023
|
oh no failing tests |
|
Coveralls is broken. I'll make a separate PR to remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.