New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate if values are whitespace only #639
Conversation
|
||
raise ValidationError, "Multiple value, groupedValue, structuredValue, and parallelValue in description: #{error_paths.join(', ')}" | ||
raise ValidationError, "Multiple value, groupedValue, structuredValue, and parallelValue in description: #{error_paths_multiple.join(', ')}" unless error_paths_multiple.empty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be able to return both kinds of errors at once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's possible, at least as written. The multiples requires the top level value
to be present and it's not when blank. Perhaps this is a topic for follow up discussion with @andrewjbtw or @arcadiafalcone
3234b0c
to
63c7075
Compare
Wondering if this is the sort of change we might want to run against a sizable subset of prod data to see how this affects validation. |
This should be validated against all items in all environments else chaos ensues. |
@mjgiarlo / @justinlittman agreed. I've marked as hold. |
@aaron-collier how long will this take to validate? We're getting hammered with these errors again/still. |
9ef7bd3
to
0ef861f
Compare
0ef861f
to
5024cc3
Compare
5024cc3
to
31fdf67
Compare
31fdf67
to
e77533f
Compare
@andrewjbtw here is a list of the druids that vail cocina validation with this change. 1073 objects. Should these be remediated before this change goes in? |
Removing hold per @andrewjbtw:
@mjgiarlo / @justinlittman ready for a follow up review. |
NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.
Why was this change made? 🤔
This is draft while wrapping up styling/refactoring...
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡