Does not close stdout when running DlmeJsonResourceWriter. Closes #54. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Feb 20, 2019
lib/dlme_json_resource_writer.rb
Outdated
| @@ -21,6 +21,10 @@ def serialize(context) | |||
| "#{JSON.pretty_generate(adjusted)}" | |||
| end | |||
|
|
|||
| def close | |||
| @output_file.close unless (@output_file.nil? || @output_file.tty? || @output_file == $stdout) | |||
There was a problem hiding this comment.
Can you explain why we need to check for tty?
There was a problem hiding this comment.
Should this patch be made upstream? https://github.com/traject/traject/blob/master/lib/traject/line_writer.rb#L60
There was a problem hiding this comment.
Can you refactor to
def close
return if @output_file == $stdout
super
end
justinlittman
force-pushed
the
justinlittman-patch-1
branch
2 times, most recently
from
0cfb665
to
4233789
Compare
|
Upstream PR: traject/traject#202 |
justinlittman
force-pushed
the
justinlittman-patch-1
branch
from
4233789
to
42eed4b
Compare
jcoyne
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
Can you please add a comment referencing that this customization is needed until traject/traject#202 is resolved?
justinlittman
force-pushed
the
justinlittman-patch-1
branch
from
42eed4b
to
7c06806
Compare
justinlittman
force-pushed
the
justinlittman-patch-1
branch
from
7c06806
to
cd6ca4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.