break out tags to its own class #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Aug 29, 2018
| def initialize(p_hash) | ||
| @name = p_hash[:name] | ||
| @value = p_hash[:value] | ||
| end |
There was a problem hiding this comment.
You could even add a to_xml method here which would return:
"<tag name=\"#{name}\" value=\"#{value}\"></tag>"There was a problem hiding this comment.
good idea, i'm going to push to this branch and then submit a new PR against master (since the goobi-tag work is now merged)
|
👏 I like this very much. Thank you. |
add <tags> to goobi notify call with object tags in specified format
|
closed in favor of #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experiment in breaking out the goobi tag into a small class instead of using array of arrays to represent