Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize dor-services-app #179

Merged
merged 1 commit into from Dec 18, 2018
Merged

Containerize dor-services-app #179

merged 1 commit into from Dec 18, 2018

Conversation

mjgiarlo
Copy link
Member

Include a working docker-compose configuration (w/ Solr configs) as an example to show dependencies, including config values. Also include dummy certs to override defaults that cause SSL errors when spinning up in test/dev environments.

@coveralls
Copy link

coveralls commented Dec 17, 2018

Coverage Status

Coverage remained the same at 99.553% when pulling a037db2 on dockerize into 3ac3b82 on master.

Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You checked in vendor/ can you remove that and add it to .gitignore?

@mjgiarlo
Copy link
Member Author

mjgiarlo commented Dec 17, 2018

@jcoyne I used vendor/ to ship the Oracle dependencies necessary for bundle install to build the ruby-oci8 gem: https://github.com/sul-dlss/dor-services-app/pull/179/files#diff-3254677a7917c6c01f55212f86c57fbfR7

Is there a better way to take care of this?

@jcoyne
Copy link
Contributor

jcoyne commented Dec 17, 2018

@mjgiarlo do they grant a license to redistribute those binaries?

@jcoyne
Copy link
Contributor

jcoyne commented Dec 17, 2018

How about bundle --without production? Can we get away with that?

@mjgiarlo
Copy link
Member Author

@jcoyne I think so? I'll give that a shot once I have the Argo build passing.

Include a working docker-compose configuration (w/ Solr configs) as an example to show dependencies, including config values. Also include dummy certs to override defaults that cause SSL errors when spinning up in test/dev environments.
@mjgiarlo
Copy link
Member Author

@jcoyne Removed.

@jcoyne jcoyne merged commit 0d2951d into master Dec 18, 2018
@mjgiarlo mjgiarlo deleted the dockerize branch January 9, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants