Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with special characters in title from any location #202

Merged
merged 2 commits into from Feb 27, 2019

Conversation

peetucket
Copy link
Member

@peetucket peetucket commented Feb 27, 2019

fixes #201

  • improve tests to confirm escaping occurs with both MODs and fedora labels

@peetucket peetucket changed the title deal with special characters in title from any location [WIP] deal with special characters in title from any location Feb 27, 2019
Copy link
Member

@jmartin-sul jmartin-sul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. is the WIP because the testing isn't yet fully implemented according to what's in the PR description?

@peetucket
Copy link
Member Author

Thanks, yes switched to WIP since I'm going to try and make the test more robust to ensure the escaping of special character occurs regardless of title source (MODs vs fedora label). The bug before was the it was occurring in one case but not the other. Expect to have that done soon, then would appreciate another quick look.

@jmartin-sul
Copy link
Member

@peetucket feel free to ping here on on slack whenever it's ready

@peetucket peetucket changed the title [WIP] deal with special characters in title from any location deal with special characters in title from any location Feb 27, 2019
@jcoyne
Copy link
Contributor

jcoyne commented Feb 27, 2019

@peetucket have you heard about Draft pull requests? They're a brand new way to share your wip: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@peetucket
Copy link
Member Author

@peetucket have you heard about Draft pull requests? They're a brand new way to share your wip: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Yeah, but didn't see a way to convert a regular PR to a WIP (I started as a regular PR, then changed my mind and wanted to add another test).

@jcoyne jcoyne merged commit d150135 into master Feb 27, 2019
@jcoyne jcoyne deleted the 201-encode-goobi-title branch February 27, 2019 22:37
@coveralls
Copy link

coveralls commented Feb 27, 2019

Coverage Status

Coverage increased (+0.001%) to 99.561% when pulling 8dc3499 on 201-encode-goobi-title into 1bdd044 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to XML encode title in goobi request
4 participants