Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mkdir and mkdir_with_final_link from DruidTools #329

Closed
wants to merge 1 commit into from
Closed

Move mkdir and mkdir_with_final_link from DruidTools #329

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Aug 15, 2019

Also moved rmdir, but it doesn't appear to be used

@jcoyne
Move mkdir and mkdir_with_final_link from DruidTools
7271cf2 
Also moved rmdir, but it doesn't appear to be used
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 97.225% when pulling 7271cf2 on rmdir into 8bab11a on master.

@mjgiarlo
Copy link
Member

@jcoyne 💬

Also moved rmdir, but it doesn't appear to be used

Here, I guess? https://github.com/sul-dlss/dor-services-app/blob/master/app/services/prune_service.rb#L21

@mjgiarlo mjgiarlo added this to Needs Review in Infrateam Aug-Sep 2019 via automation Aug 15, 2019
@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 15, 2019

@mjgiarlo nope, that's a Pathname

@jcoyne
Copy link
Contributor Author

jcoyne commented Aug 15, 2019

Closing, because I'm seeing mkdir is used elsewhere in druidTools.

@jcoyne jcoyne closed this Aug 15, 2019
Infrateam Aug-Sep 2019 automation moved this from Needs Review to Done Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Infrateam Aug-Sep 2019
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @mjgiarlo