Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API documentation #381

Merged
merged 1 commit into from Sep 10, 2019
Merged

Add API documentation #381

merged 1 commit into from Sep 10, 2019

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Sep 10, 2019

This has all of the endpoints, but doesn't yet have all the parameters and responses.

@coveralls
Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage remained the same at 97.234% when pulling 0b2f96f on docs into 4453705 on master.

Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Have a single recommendation re: the README change. Love to see this happening! Thanks for taking this on.

README.md Outdated
This Ruby application provides a REST API for DOR Services. [View the REST API documentation](https://consul.stanford.edu/display/chimera/REST+mappings+for+dor-services+gem).

This Ruby application provides a REST API for DOR Services.
There is a OAS 3.0 spec that documents the API in [openapi.json]. If you clone this repo, you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you unpack "OAS" and/or link somewhere relevant? (Yeah, I know, OpenAPI.)




## Was the API documentation (openapi.json) updated?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</style>
</head>
<body>
<redoc spec-url='https://raw.githubusercontent.com/sul-dlss/dor-services-app/master/openapi.json'></redoc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radical

This has all of the endpoints, but doesn't yet have all the parameters and responses.
@jcoyne jcoyne merged commit 838c8f4 into master Sep 10, 2019
Infrateam Aug-Sep 2019 automation moved this from Needs Review to Done Sep 10, 2019
@jcoyne jcoyne deleted the docs branch September 10, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants