Accept the Authorization header #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
approved these changes
Sep 12, 2019
| @@ -25,6 +26,9 @@ def check_auth_token | |||
| return render json: { error: 'Not Authorized' }, status: :unauthorized unless token | |||
|
|
|||
| Honeybadger.context(invoked_by: token[:sub]) | |||
| return unless request.headers[OLD_TOKEN_HEADER] | |||
|
|
|||
| Honeybadger.notify("Deprecated authentication header '#{OLD_TOKEN_HEADER}' was provided, but '#{TOKEN_HEADER}' is expected") | |||
There was a problem hiding this comment.
s/authentication/authorization/ ?
There was a problem hiding this comment.
Thank you! I fixed it.
Log a honeybadger notification when we get the old X-Auth header Fixes #320
|
@jcoyne 🐑 it |
|
Should we look to do lots o' shared configs PRs tomorrow and Friday so Monday morning updates can reduce the number of hb alerts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log a honeybadger notification when we get the old X-Auth header
Fixes #320
Why was this change made?
We want to be able to accept the standard Authorization header rather than our custom X-Auth header.
Was the API documentation (openapi.json) updated?
Yes!