Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove current children from virtual object before initializing content metadata #418

Merged
merged 3 commits into from Sep 17, 2019

Conversation

mjgiarlo
Copy link
Member

Fixes #409

This prevents a situation where lots of manual clean-up is required to remove old children from a parent.

Also includes:

  • Ignore postgres data directory created by docker-compose service
  • Correct typo in RefreshMetadataAction spec description

Why was this change made?

To satisfy the new virtual object creation requirement surfaced in #409.

Was the API documentation (openapi.json) updated?

N/A

@mjgiarlo mjgiarlo force-pushed the remove_children_first_409 branch 2 times, most recently from a9b9f1e to 9d2b1c6 Compare September 17, 2019 17:54
spec/services/constituent_service_spec.rb Outdated Show resolved Hide resolved
…nt metadata

This prevents a situation where lots of manual clean-up is required to remove old children from a parent.

Fixes #409
@jcoyne jcoyne merged commit 673dab0 into master Sep 17, 2019
@mjgiarlo mjgiarlo deleted the remove_children_first_409 branch September 17, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Before adding children to a parent virtual object, first remove any children attached to the parent
2 participants