Handle virtual object creation in a background job #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Sep 18, 2019
mjgiarlo
force-pushed
the
bg_virtobj_336
branch
from
53230c0
to
ce48348
Compare
|
@jcoyne 💬
Included now. |
mjgiarlo
force-pushed
the
bg_virtobj_336
branch
7 times, most recently
from
23991be
to
8699868
Compare
Connects to #336 This makes it possible to reliably stash information about background jobs in a persistent store, which will be used to run virtual object creation in the background. Includes `factory_bot_rails` as a dependency which will make it easier to spin up fixture-like factories when testing with database entities later.
Connects to #336 The model holds any output from the job, an HTTP status code, and a processing status.
Connects to #336 This allows us to test database-backed entities, specifically BackgroundJobResults, more efficently.
Connects to #336 And use the new job from the CreateVirtualObjectsController. In the job, record progress and results in the application database.
mjgiarlo
force-pushed
the
bg_virtobj_336
branch
from
8699868
to
bbed3cc
Compare
jcoyne
reviewed
Sep 18, 2019
| class CreateBackgroundJobResults < ActiveRecord::Migration[5.2] | ||
| def up | ||
| execute <<-SQL | ||
| CREATE TYPE background_job_result_status AS ENUM ( |
There was a problem hiding this comment.
Great! We should port this to workflow-service.
jcoyne
reviewed
Sep 19, 2019
jcoyne
reviewed
Sep 19, 2019
jcoyne
requested changes
Sep 19, 2019
mjgiarlo
force-pushed
the
bg_virtobj_336
branch
from
bbed3cc
to
34600a2
Compare
…l_objects endpoints
mjgiarlo
force-pushed
the
bg_virtobj_336
branch
from
34600a2
to
d856d98
Compare
jcoyne
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #336
Deployment blocked by sul-dlss/puppet#4470factory_bot_railsas a dependency which will make it easier to spinup fixture-like factories when testing with database entities later.
BackgroundJobResults.CreateVirtualObjectsController. In the job, record progress and results in the application databaseWhy was this change made?
To be able to process large batches of virtual objects outside of the request/response cycle.
Was the API documentation (openapi.json) updated?
Yes.