Avoid looking for release tags in PURL #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
requested changes
Oct 15, 2019
| @@ -16,7 +16,10 @@ def initialize(item) | |||
| def publish | |||
| return unpublish unless world_discoverable? | |||
|
|
|||
| transfer_metadata | |||
| # Retrieve release tags from metadata and PURL | |||
There was a problem hiding this comment.
maybe update this code comment since we no longer update release tags from PURL?
This behavior was originally introduced here: sul-dlss-deprecated/dor-services@439b808#diff-8200ce146e3aa5427aa3d4f563164195R81-R82 but none of us (including Ben) can understand why this would be necessary. Since this slows things down and adds fragility, remove it.
peetucket
approved these changes
Oct 15, 2019
mjgiarlo
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
This behavior was originally introduced here: sul-dlss-deprecated/dor-services@439b808#diff-8200ce146e3aa5427aa3d4f563164195R81-R82 but none of us (including Ben) can understand why this would be necessary. Since this slows things down and adds fragility, remove it.
Was the API documentation (openapi.json) updated?
N/A.