Provide error handling for when the directory can't be deleted #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
reviewed
Nov 1, 2019
| @@ -23,6 +23,8 @@ def destroy | |||
| head :no_content | |||
| rescue Errno::ENOENT => e | |||
| render build_error('Unable to remove directory', e) | |||
| rescue Errno::ENOTEMPTY => e | |||
There was a problem hiding this comment.
Not important, but since the behavior/message is the same on lines 25 and 27, I'm curious why you didn't do:
rescue Errno::ENOENT, Errno::ENOTEMPTY => e
render build_error('Unable to remove directory', e)There was a problem hiding this comment.
I was hoping rubocop would do it for me. 😆
jcoyne
force-pushed
the
better-errors2
branch
from
d5b3ed1
to
85aeb9a
Compare
mjgiarlo
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Better errors when a directory can't be deleted.
Was the API documentation (openapi.json) updated?
n/a