Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#body_params should fallback to an empty hash #51

Merged
merged 4 commits into from
Jan 5, 2017

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Jan 4, 2017

No description provided.

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked @cbeer offline if there should be a test.

"the important parts are covered already, so this should just be a straight refactor. it just happens that what rails tests use and what passenger provides are slightly different."

LGTM. 👍 for merging

@ndushay
Copy link
Contributor

ndushay commented Jan 5, 2017

"the problem is rack doesn’t define what request.body returns, and passenger chose something more restrictive than whatever the rails test harness provides."

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage increased (+0.6%) to 98.558% when pulling b5b12dc on body-params-fallback into ce95e8d on master.

@ndushay ndushay merged commit 9a5753b into master Jan 5, 2017
@ndushay ndushay deleted the body-params-fallback branch January 5, 2017 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants