Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

Extract ReleaseTagService from Releasable #396

Merged
merged 1 commit into from Dec 3, 2018
Merged

Extract ReleaseTagService from Releasable #396

merged 1 commit into from Dec 3, 2018

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Nov 30, 2018

Trying to limit the number of responsibilities that any one class has.

@jcoyne
Extract ReleaseTagService from Releasable
cdccf45 
Trying to limit the number of responsibilities that any one class has.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 91.503% when pulling cdccf45 on release-tags into 0ec5e5a on master.

mjgiarlo
mjgiarlo approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with same rationale as #393. Looking good, @jcoyne!

@mjgiarlo mjgiarlo merged commit cc004eb into master Dec 3, 2018
@mjgiarlo mjgiarlo deleted the release-tags branch December 3, 2018 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjgiarlo mjgiarlo mjgiarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcoyne @coveralls @mjgiarlo