Merge 33ce1d3 into 80b4498

sul-dlss · Jun 18, 2020 · 1af28d7 · 1af28d7
2 parents 80b4498 + 33ce1d3
commit 1af28d7
Show file tree

Hide file tree

Showing 53 changed files with 99 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -56,9 +56,6 @@ RSpec/ExampleLength:
 
 # --- Style ---
 
-Style/FrozenStringLiteralComment:
-  Enabled: false # avoid cruft in our files for something that MAY be default in Ruby 3.0
-
 Style/IfUnlessModifier:
   Enabled: false
     # robots/gisAssembly/extract-boundingbox.rb # line 233 unless ulx <= lrx && uly >= lry

diff --git a/Capfile b/Capfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load DSL and Setup Up Stages
 require 'capistrano/setup'
 

diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'assembly-objectfile'

diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake'
 require 'resque/pool/tasks'
 

diff --git a/bin/console b/bin/console
@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 # To start an pry session with gems and configuration loaded:
 # [robot_root] $ ./bin/console development
 ENV['ROBOT_ENVIRONMENT'] = ARGV.shift unless ARGV.first.nil?

diff --git a/config/boot.rb b/config/boot.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Ensure subsequent requires search the correct local paths
 $LOAD_PATH.unshift File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
 

diff --git a/config/deploy.rb b/config/deploy.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 set :application, 'gisRobotSuite'
 set :repo_url, 'https://github.com/sul-dlss/gis-robot-suite.git'
 

diff --git a/config/deploy/prod.rb b/config/deploy/prod.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 server 'kurma-robots1-prod.stanford.edu', user: 'lyberadmin', roles: %w(web app db)
 
 Capistrano::OneTimeKey.generate_one_time_key!

diff --git a/config/deploy/stage.rb b/config/deploy/stage.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 server 'kurma-robots1-stage.stanford.edu', user: 'lyberadmin', roles: %w(web app db)
 
 Capistrano::OneTimeKey.generate_one_time_key!

diff --git a/config/environments/example.rb b/config/environments/example.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 cert_dir = File.join(File.dirname(__FILE__), '..', 'certs')
 
 Dor::Config.configure do

diff --git a/config/environments/local.rb b/config/environments/local.rb
@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 REDIS_URL = 'localhost:6379/resque:local'
diff --git a/config/environments/production.rb b/config/environments/production.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dor::Config.configure do
   fedora do
     url Settings.fedora.url

diff --git a/config/environments/staging.rb b/config/environments/staging.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dor::Config.configure do
   fedora do
     url Settings.fedora.url

diff --git a/config/environments/test.rb b/config/environments/test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 REDIS_URL = Settings.redis.url
 
 ENV['RGEOSERVER_CONFIG'] ||= File.expand_path(File.join(File.dirname(__FILE__), ENV['ROBOT_ENVIRONMENT'] + '_rgeoserver.yml'))
diff --git a/lib/gis_robot_suite.rb b/lib/gis_robot_suite.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GisRobotSuite
   def self.initialize_robot(druid)
     n = 5 # seconds

diff --git a/lib/gis_robot_suite/gazetteer.rb b/lib/gis_robot_suite/gazetteer.rb
@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 require 'csv'
 

diff --git a/lib/robots/dor_repo/gis_assembly/approve_data.rb b/lib/robots/dor_repo/gis_assembly/approve_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/approve_metadata.rb b/lib/robots/dor_repo/gis_assembly/approve_metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/assign_placenames.rb b/lib/robots/dor_repo/gis_assembly/assign_placenames.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/author_metadata.rb b/lib/robots/dor_repo/gis_assembly/author_metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/extract_boundingbox.rb b/lib/robots/dor_repo/gis_assembly/extract_boundingbox.rb
@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 require 'fileutils'
 require 'scanf'

diff --git a/lib/robots/dor_repo/gis_assembly/extract_iso19139.rb b/lib/robots/dor_repo/gis_assembly/extract_iso19139.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/extract_thumbnail.rb b/lib/robots/dor_repo/gis_assembly/extract_thumbnail.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 
 # Robot class to run under multiplexing infrastructure

diff --git a/lib/robots/dor_repo/gis_assembly/finish_data.rb b/lib/robots/dor_repo/gis_assembly/finish_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/finish_gis_assembly_workflow.rb b/lib/robots/dor_repo/gis_assembly/finish_gis_assembly_workflow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 
 # Robot class to run under multiplexing infrastructure

diff --git a/lib/robots/dor_repo/gis_assembly/finish_metadata.rb b/lib/robots/dor_repo/gis_assembly/finish_metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/generate_content_metadata.rb b/lib/robots/dor_repo/gis_assembly/generate_content_metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fastimage'
 require 'mime/types'
 require 'assembly-objectfile'

diff --git a/lib/robots/dor_repo/gis_assembly/generate_geo_metadata.rb b/lib/robots/dor_repo/gis_assembly/generate_geo_metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/generate_mods.rb b/lib/robots/dor_repo/gis_assembly/generate_mods.rb
@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 require 'scanf'
 

diff --git a/lib/robots/dor_repo/gis_assembly/load_geo_metadata.rb b/lib/robots/dor_repo/gis_assembly/load_geo_metadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/normalize_data.rb b/lib/robots/dor_repo/gis_assembly/normalize_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'open-uri'
 
 # Robot class to run under multiplexing infrastructure

diff --git a/lib/robots/dor_repo/gis_assembly/package_data.rb b/lib/robots/dor_repo/gis_assembly/package_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/start_assembly_workflow.rb b/lib/robots/dor_repo/gis_assembly/start_assembly_workflow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/start_delivery_workflow.rb b/lib/robots/dor_repo/gis_assembly/start_delivery_workflow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_assembly/wrangle_data.rb b/lib/robots/dor_repo/gis_assembly/wrangle_data.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_delivery/finish_gis_delivery_workflow.rb b/lib/robots/dor_repo/gis_delivery/finish_gis_delivery_workflow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_delivery/load_geoserver.rb b/lib/robots/dor_repo/gis_delivery/load_geoserver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rgeoserver'
 require 'druid-tools'
 require 'mods'

diff --git a/lib/robots/dor_repo/gis_delivery/load_geowebcache.rb b/lib/robots/dor_repo/gis_delivery/load_geowebcache.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_delivery/load_raster.rb b/lib/robots/dor_repo/gis_delivery/load_raster.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_delivery/load_vector.rb b/lib/robots/dor_repo/gis_delivery/load_vector.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_delivery/seed_geowebcache.rb b/lib/robots/dor_repo/gis_delivery/seed_geowebcache.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_delivery/start_gis_discovery_workflow.rb b/lib/robots/dor_repo/gis_delivery/start_gis_discovery_workflow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_discovery/export_opengeometadata.rb b/lib/robots/dor_repo/gis_discovery/export_opengeometadata.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 # Robot class to run under multiplexing infrastructure

diff --git a/lib/robots/dor_repo/gis_discovery/finish_gis_discovery_workflow.rb b/lib/robots/dor_repo/gis_discovery/finish_gis_discovery_workflow.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Robot class to run under multiplexing infrastructure
 module Robots       # Robot package
   module DorRepo    # Use DorRepo/SdrRepo to avoid name collision with Dor module

diff --git a/lib/robots/dor_repo/gis_discovery/generate_geoblacklight.rb b/lib/robots/dor_repo/gis_discovery/generate_geoblacklight.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'date' # for rfc3339
 require 'geo_combine'
 

diff --git a/lib/robots/dor_repo/gis_discovery/load_geoblacklight.rb b/lib/robots/dor_repo/gis_discovery/load_geoblacklight.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rsolr'
 
 # Robot class to run under multiplexing infrastructure

diff --git a/lib/tasks/console.rake b/lib/tasks/console.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 desc 'Run a console booted with robots'
 task :console, :ROBOT_ENVIRONMENT do |_t, args|
   args.with_defaults(ROBOT_ENVIRONMENT: 'development')

diff --git a/spec/robots/dor_repo/gis_assembly/generate_mods_spec.rb b/spec/robots/dor_repo/gis_assembly/generate_mods_spec.rb
@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

diff --git a/spec/robots/dor_repo/gis_assembly/load_geo_metadata_spec.rb b/spec/robots/dor_repo/gis_assembly/load_geo_metadata_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Robots::DorRepo::GisAssembly::LoadGeoMetadata do

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Make sure specs run with the definitions from local.rb
 ENV['ROBOT_ENVIRONMENT'] ||= 'test'
 

diff --git a/spec/unit/gazetteer_spec.rb b/spec/unit/gazetteer_spec.rb
@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 require 'spec_helper'
 

diff --git a/spec/unit/trivial_spec.rb b/spec/unit/trivial_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe 'booting' do

diff --git a/spec/unit/utils_spec.rb b/spec/unit/utils_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'utilities' do