Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Collection model #123

Merged
merged 1 commit into from Oct 10, 2020
Merged

Add the Collection model #123

merged 1 commit into from Oct 10, 2020

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Oct 9, 2020

Why was this change made?

So that we can establish the Work-Collection relationship.

How was this change tested?

Which documentation and/or configurations were updated?

db/schema.rb Outdated
@@ -1,4 +1,3 @@
# typed: strict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you restore this? Or would you prefer to handle otherwise?

Copy link
Contributor Author

@jcoyne jcoyne Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this was just db:migrate that made things this way. However, I think this will be the same ever time we do a migration.

Copy link
Member

@mjgiarlo mjgiarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about db/schema.rb and sorbet.

@mjgiarlo mjgiarlo merged commit 830ae63 into main Oct 10, 2020
@mjgiarlo mjgiarlo deleted the collection-model branch October 10, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants