Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional date parsing and normalization for downstream consumer… #25

Merged
merged 2 commits into from Dec 1, 2017

Conversation

cbeer
Copy link
Member

@cbeer cbeer commented Nov 29, 2017

…s to extract actionable information from a variety of date encodings.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.4%) to 99.121% when pulling 8ef5ef9 on date-parsing-is-hard into 846ff0b on master.

@cbeer cbeer force-pushed the date-parsing-is-hard branch 2 times, most recently from c80508e to ba85413 Compare November 29, 2017 16:48
@cbeer cbeer changed the title Add additional date parsing and normalization for downstream consumer… [WIP] Add additional date parsing and normalization for downstream consumer… Nov 29, 2017
@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.5%) to 98.96% when pulling ba85413 on date-parsing-is-hard into 846ff0b on master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.4%) to 99.147% when pulling ba85413 on date-parsing-is-hard into 846ff0b on master.

@cbeer cbeer force-pushed the date-parsing-is-hard branch 2 times, most recently from a11ce1d to 9f32117 Compare November 29, 2017 17:24
@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.09%) to 99.414% when pulling 9f32117 on date-parsing-is-hard into 846ff0b on master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage decreased (-0.09%) to 99.414% when pulling 9f32117 on date-parsing-is-hard into 846ff0b on master.

@cbeer cbeer force-pushed the date-parsing-is-hard branch 2 times, most recently from 83a0919 to c723cfc Compare November 29, 2017 17:34
@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.02%) to 99.525% when pulling c723cfc on date-parsing-is-hard into 846ff0b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.525% when pulling c723cfc on date-parsing-is-hard into 846ff0b on master.

@cbeer cbeer changed the title [WIP] Add additional date parsing and normalization for downstream consumer… Add additional date parsing and normalization for downstream consumer… Nov 29, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.543% when pulling c723cfc on date-parsing-is-hard into 846ff0b on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.04%) to 99.543% when pulling c723cfc on date-parsing-is-hard into 846ff0b on master.

Mods::Date::MarcFormat.new(xml)
when 'edtf'
Mods::Date::EdtfFormat.new(xml)
# when 'temper'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported? Should this be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stanford doesn't have any examples of this, but it's called out as one of the supported MODS formats. I figured a comment was the best way to leave a clue about where one might add support if they cared. 🤷‍♂️

Copy link
Contributor

@drh-stanford drh-stanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. My only comment is that the cleanup functions are using the same/similar regular expressions as your big case statement for routing to the appropriate Date class. So those might be shared with a comment containing an example of that format.

@cbeer
Copy link
Member Author

cbeer commented Nov 29, 2017

@drh-stanford: how about 278ea0b?

@drh-stanford
Copy link
Contributor

Yes, I find that more readable. Thanks

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.04%) to 99.542% when pulling 278ea0b on date-parsing-is-hard into 846ff0b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 99.542% when pulling 278ea0b on date-parsing-is-hard into 846ff0b on master.

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage increased (+0.04%) to 99.542% when pulling cb779b1 on date-parsing-is-hard into 846ff0b on master.

@mejackreed
Copy link
Contributor

With @drh-stanford 's comment being addressed.. 👍

@mejackreed mejackreed merged commit 23685f6 into master Dec 1, 2017
@mejackreed mejackreed deleted the date-parsing-is-hard branch December 1, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants