Date accessors #26

cbeer · 2017-12-01T18:59:19Z

No description provided.

coveralls · 2017-12-01T19:02:21Z

Coverage increased (+0.003%) to 99.545% when pulling f9a9bb5 on date-accessors into 48b6a8c on master.

coveralls · 2017-12-01T21:04:22Z

Coverage increased (+0.006%) to 99.548% when pulling 61f2d06 on date-accessors into 48b6a8c on master.

coveralls · 2017-12-01T21:16:49Z

Coverage increased (+0.007%) to 99.549% when pulling 3c90bb6 on date-accessors into 48b6a8c on master.

coveralls · 2017-12-04T17:46:36Z

Coverage decreased (-0.04%) to 99.499% when pulling 69944a5 on date-accessors into 48b6a8c on master.

jcoyne · 2017-12-04T18:48:21Z

lib/mods/date.rb


-        text.gsub(/^[\[]+/, '').gsub(/[\.\]]+$/, '')
+        Date.cleanup(text)


Can you call super here?

jcoyne · 2017-12-04T18:48:58Z

lib/mods/date.rb

@@ -95,11 +102,11 @@ def self.supports?(text)

    # Full text extractor for MM/DD/YYYY-formatted dates


Does this comment need to change? Are we accepting 3 digit years now?

jcoyne · 2017-12-04T18:49:54Z

lib/mods/date.rb


      def self.cleanup(text)
        matches = text.match(REGEX)
        roman_to_int(matches[:year].upcase).to_s
      end

      def self.roman_to_int(value)
-        value = value.dup
+        value = value.dup.tr('.', '')


Do we need to dup if we're running a tr won't that create a copy for you?

jcoyne · 2017-12-04T18:50:17Z

lib/mods/date.rb

@@ -145,9 +152,10 @@ def self.roman_to_int(value)
      end
    end

-    # Full-text extractor for centuries encoded as Roman numerals
+    # Full-text extractor for centuries encoded as Roman numerals; sometimes centuries
+    # are given as e.g. xvith, hence the funny negative look-ahead assertion


jcoyne · 2017-12-04T18:51:04Z

lib/mods/date.rb

@@ -181,16 +189,77 @@ def self.cleanup(text)
      end
    end

+    # Full-text extractor for data formatted as YYYY-YYYY


or YYY-YYY?

jcoyne · 2017-12-04T18:52:02Z

lib/mods/date.rb

+    class YearRangeFormat < ExtractorDateFormat
+      REGEX = /(?<start>\d{3,4})-(?<end>\d{3,4})/
+
+      def self.cleanup(text)


Add a comment that this normalizes to YYYY/YYYY

jcoyne · 2017-12-04T18:52:35Z

lib/mods/date.rb

+
+      def self.cleanup(text)
+        matches = text.match(REGEX)
+        "#{matches[:year]}X"


What does this mean? Can you leave a comment?

jcoyne · 2017-12-04T18:53:06Z

lib/mods/date.rb

+    class EmbeddedBCYearFormat < ExtractorDateFormat
+      REGEX = /(?<year>\d{3,4})\s?B\.?C\.?/i
+
+      def self.cleanup(text)


add comment that this normalizes to -YYYY

All of these methods normalize to EDTF. I'm not sure a comment on each of them is particularly compelling?

I will rename cleanup to normalize_to_edtf for clarity.

jcoyne · 2017-12-04T18:53:44Z

lib/mods/date.rb

    # Full-text extractor that tries hard to pick any year present in the data
    class EmbeddedYearFormat < ExtractorDateFormat
-      REGEX = /(?<prefix>-)?(?<year>\d{3,4})/
+      REGEX = /(?<prefix>-)?(?<!\d)(?<year>\d{4})(?!\d)/


Can you give an example of what a prefix might be?

The regex is matching just a literal -.

jcoyne · 2017-12-04T18:54:47Z

lib/mods/date.rb

+
+    # Full-text extractor that tries hard to pick any year present in the data
+    class EmbeddedYearWithBracketsFormat < ExtractorDateFormat
+      # [YYY]Y Y[YYY] [YY]YY Y[YY]Y YY[YY] YYY[Y] YY[Y]Y Y[Y]YY [Y]YYY


Woah. 😱 Can you add a comment about what this stuff means? Is there a part of a spec I can look at?

No, I have no idea where it comes from, I just know we have lots of it.

coveralls · 2017-12-04T18:58:23Z

Coverage decreased (-0.04%) to 99.499% when pulling 7885fc5 on date-accessors into 48b6a8c on master.

coveralls · 2017-12-04T19:19:01Z

Coverage decreased (-0.04%) to 99.499% when pulling fcb7620 on date-accessors into 48b6a8c on master.

coveralls · 2017-12-04T19:33:41Z

Coverage decreased (-0.04%) to 99.499% when pulling 73be57e on date-accessors into 48b6a8c on master.

cbeer added 2 commits December 1, 2017 10:53

Add accessor for checking if a date is a 'key' date

c0c7f2c

Add accessor for getting the precision/specification level for a date

f9a9bb5

Refactor earliest + latest date logic for clarity

0f9ca2a

Handle additional date formats

3c90bb6

cbeer force-pushed the date-accessors branch from 61f2d06 to 3c90bb6 Compare December 1, 2017 21:11

jcoyne reviewed Dec 4, 2017

View reviewed changes

lib/mods/date.rb Outdated

text.gsub(/^[\[]+/, '').gsub(/[\.\]]+$/, '')

Date.cleanup(text)

Copy link

Contributor

jcoyne Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call super here?

cbeer force-pushed the date-accessors branch from 69944a5 to 7885fc5 Compare December 4, 2017 18:52

jcoyne requested changes Dec 4, 2017

View reviewed changes

cbeer force-pushed the date-accessors branch 3 times, most recently from 7d6c472 to fcb7620 Compare December 4, 2017 19:11

Refine date parsing to improve accuracy

73be57e

cbeer force-pushed the date-accessors branch from fcb7620 to 73be57e Compare December 4, 2017 19:30

jcoyne approved these changes Dec 4, 2017

View reviewed changes

drh-stanford merged commit 4be5b88 into master Dec 5, 2017

drh-stanford deleted the date-accessors branch December 5, 2017 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Date accessors #26

Date accessors #26

cbeer commented Dec 1, 2017

coveralls commented Dec 1, 2017 •

edited

Loading

coveralls commented Dec 1, 2017 •

edited

Loading

coveralls commented Dec 1, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

cbeer Dec 4, 2017

cbeer Dec 4, 2017

jcoyne Dec 4, 2017

cbeer Dec 4, 2017 •

edited

Loading

jcoyne Dec 4, 2017

jcoyne Dec 4, 2017

cbeer Dec 4, 2017

coveralls commented Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading


		text.gsub(/^[\[]+/, '').gsub(/[\.\]]+$/, '')
		Date.cleanup(text)

		@@ -95,11 +102,11 @@ def self.supports?(text)

		# Full text extractor for MM/DD/YYYY-formatted dates

Date accessors #26

Date accessors #26

Conversation

cbeer commented Dec 1, 2017

coveralls commented Dec 1, 2017 • edited Loading

coveralls commented Dec 1, 2017 • edited Loading

coveralls commented Dec 1, 2017 • edited Loading

coveralls commented Dec 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cbeer Dec 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Dec 4, 2017 • edited Loading

coveralls commented Dec 4, 2017 • edited Loading

coveralls commented Dec 4, 2017 • edited Loading

coveralls commented Dec 1, 2017 •

edited

Loading

coveralls commented Dec 1, 2017 •

edited

Loading

coveralls commented Dec 1, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

cbeer Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading

coveralls commented Dec 4, 2017 •

edited

Loading