Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test fixtures valid where they should be #218

Closed
jmartin-sul opened this issue Sep 7, 2018 · 3 comments
Closed

make test fixtures valid where they should be #218

jmartin-sul opened this issue Sep 7, 2018 · 3 comments
Assignees

Comments

@jmartin-sul
Copy link
Member

reduced scope of options have rendered some of the configs for our test fixtures invalid (see #207).

for configs for test cases where we don't intend to test an invalid config, we should make the conform to our current expectations.

@atz
Copy link
Contributor

atz commented Sep 7, 2018

More to the point, it is likely many of the fixtures can be collapsed. To the extent they were created to be "same_as_other_fixture_but_x_is_false", when we remove X, we get rid of the need for a separate fixture.

We can also get away from using YAML as the reference-point and basically start from a params hash.

W/ OO classes we can also use mocking to much greater effect. Instead of a whole separate YAML file, just use the same fixture with allow(obj).to receive(:x).and_return(false). Way more clear about test intent than having to pull up a YAML file.

@ndushay
Copy link
Contributor

ndushay commented Sep 10, 2018

We should also rename the folders (or copy them) to more descriptive names.

@ndushay
Copy link
Contributor

ndushay commented Sep 15, 2018

I'm calling this done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants