-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 2 more styles of test data per #199 #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
force-pushed
the
more-test-data
branch
from
September 11, 2018 20:14
aeb9fea
to
8384480
Compare
ndushay
force-pushed
the
more-test-data
branch
from
September 11, 2018 20:17
8384480
to
ebb734e
Compare
ndushay
force-pushed
the
more-test-data
branch
from
September 11, 2018 20:21
ebb734e
to
9550318
Compare
ndushay
force-pushed
the
more-test-data
branch
from
September 11, 2018 20:54
9550318
to
f743d3c
Compare
jmartin-sul
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to ensure we have test_data that mimics the data we actually expect.
The next idea is for our test data folders to be named so we know what's in them.
My intent is that we eventually get rid of the bundle_input_xxx directories. Happy to add such commits here, if folks want. Happy to make a follow-on ticket.
Mostly, wanted to ensure we could run the code with the test data mentioned in #199. I ran the discovery report in the console for these new dirs (and for images_jp2_tif)
connects to #199
connects to #218