Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 more styles of test data per #199 #241

Merged
merged 9 commits into from
Sep 12, 2018
Merged

add 2 more styles of test data per #199 #241

merged 9 commits into from
Sep 12, 2018

Conversation

ndushay
Copy link
Contributor

@ndushay ndushay commented Sep 11, 2018

The main idea is to ensure we have test_data that mimics the data we actually expect.

The next idea is for our test data folders to be named so we know what's in them.

My intent is that we eventually get rid of the bundle_input_xxx directories. Happy to add such commits here, if folks want. Happy to make a follow-on ticket.

Mostly, wanted to ensure we could run the code with the test data mentioned in #199. I ran the discovery report in the console for these new dirs (and for images_jp2_tif)

connects to #199
connects to #218

@ndushay ndushay added the review label Sep 11, 2018
@coveralls
Copy link

coveralls commented Sep 11, 2018

Pull Request Test Coverage Report for Build 768

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.22%

Totals Coverage Status
Change from base Build 764: 0.0%
Covered Lines: 601
Relevant Lines: 998

💛 - Coveralls

@jmartin-sul jmartin-sul merged commit 915c1c9 into master Sep 12, 2018
@jmartin-sul jmartin-sul deleted the more-test-data branch September 12, 2018 00:32
SaravShah added a commit that referenced this pull request Sep 14, 2018
Remove unused test data (depends on #233 , depends on #241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants