Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test data: add smpl_multimedia and config yaml for it #233

Merged
merged 5 commits into from
Sep 13, 2018
Merged

test data: add smpl_multimedia and config yaml for it #233

merged 5 commits into from
Sep 13, 2018

Conversation

ndushay
Copy link
Contributor

@ndushay ndushay commented Sep 10, 2018 •
edited
Loading

This is basically bundle_input_e with a better name and a project yaml file that is configured for it.

Connects to #218
Connects to #199

@ndushay ndushay added the review label Sep 10, 2018
@coveralls
Copy link

coveralls commented Sep 10, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 859

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.569%
Totals Coverage Status
Change from base Build 851: 0.0%
Covered Lines: 521
Relevant Lines: 905
💛 - Coveralls

@ndushay ndushay mentioned this pull request Sep 11, 2018
Merged
@ndushay ndushay mentioned this pull request Sep 11, 2018
Merged
@atz
Copy link
Contributor

atz commented Sep 12, 2018

This seems certain to conflict w/ Sarav's PR

@ndushay
Copy link
Contributor Author

ndushay commented Sep 12, 2018

i can redo this after #256. For the record, this was up to be merged well before Sarav started on #256.

@atz
Copy link
Contributor

atz commented Sep 13, 2018

Only a couple minor conflicts, rn.

@ndushay
Copy link
Contributor Author

ndushay commented Sep 13, 2018

this has been rebased and is ready for review

@atz atz merged commit db58c82 into master Sep 13, 2018
@atz atz removed the review label Sep 13, 2018
@atz atz deleted the smpl-test-data branch September 13, 2018 23:52
SaravShah added a commit that referenced this pull request Sep 14, 2018
@SaravShah
Merge pull request #248 from sul-dlss/remove-unused-test-data
e680546 
Remove unused test data (depends on #233 , depends on #241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atz atz atz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndushay @coveralls @atz