Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime error should not be logged in Honeybadger #560

Closed
jcoyne opened this issue Oct 29, 2019 · 0 comments · Fixed by #595
Closed

Runtime error should not be logged in Honeybadger #560

jcoyne opened this issue Oct 29, 2019 · 0 comments · Fixed by #595
Labels
tech debt

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Oct 29, 2019

Describe the bug
This RuntimeError https://github.com/sul-dlss/pre-assembly/blob/master/app/lib/pre_assembly/digital_object.rb#L91 is being caught by Honeybadger.

It seems this is a data error and should just be presented to the user and not go into HB.
@jcoyne jcoyne changed the title Runtime error should not be logged in Honeybadgerr Runtime error should not be logged in Honeybadger Oct 29, 2019
jcoyne added a commit that referenced this issue Dec 18, 2019
@jcoyne
Show an error to the users if their job fails
daaf805 
Presently, it just raises an error and the user never sees their job complete.
Fixes #560
@jcoyne jcoyne mentioned this issue Dec 18, 2019
Merged
jcoyne added a commit that referenced this issue Dec 18, 2019
@jcoyne
Show an error to the users if their job fails
d75c2c6 
Presently, it just raises an error and the user never sees their job complete.
Fixes #560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show an error to the users if their job fails sul-dlss/pre-assembly
1 participant
@jcoyne