Rubocop applications #365
Merged
Rubocop applications #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atz
commented
Sep 26, 2018
| @@ -16,40 +14,30 @@ | |||
|
|
|||
| module PreAssembly | |||
| class Smpl | |||
| include PreAssembly::Logging | |||
There was a problem hiding this comment.
Note: wasn't actually using Logging!
atz
commented
Sep 26, 2018
| @@ -101,7 +100,7 @@ def manifest_cols | |||
| private | |||
|
|
|||
| def normalize_dir(dir) | |||
| dir.chomp('/') if dir | |||
| dir&.chomp('/') | |||
There was a problem hiding this comment.
I've been waiting so long for (1) Ruby to get a safe accessor, and (2) for its use to become conventional. Woo!
There was a problem hiding this comment.
yeah, i really like this too, it's a very nice usability enhancement.
Pull Request Test Coverage Report for Build 1147
💛 - Coveralls |
- accessors not needed, use readers instead - actually use the readers instead of instance vars in methods - remove `puts` statement and related `verbose` option - initialize `@manifest` in `#initialize` - some beautification
Excludes `StringLiterals` and `HashSyntax` as high churn for now.
Merged
jmartin-sul
reviewed
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 manual commits (Lint errors and Smpl.rb cleanup), otherwise all auto-corrections run by category.
Note this includes Performance and Security (yaml safe load) fixes.
I excluded
HashSyntaxandStringLiteralswhich would touch another 350 lines. I also did not doRSpecfixes, which tend to be more capricious.If this gets merged, I'll probably follow up with those and wire rubocop into CI.