Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail template #368

Merged
merged 3 commits into from
Sep 27, 2018
Merged

Mail template #368

merged 3 commits into from
Sep 27, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Sep 27, 2018

Provides the essential link back to JobRunsController#show. This is small, so merging #365 first makes sense.

Part of #318

This is required to even call `url_for` in a mailer template.
Also standardizes the languages between subject and body.
@atz atz added the review label Sep 27, 2018
@coveralls
Copy link

coveralls commented Sep 27, 2018

Pull Request Test Coverage Report for Build 1158

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 88.536%

Totals Coverage Status
Change from base Build 1148: 0.04%
Covered Lines: 502
Relevant Lines: 567

💛 - Coveralls

@atz atz mentioned this pull request Sep 27, 2018
3 tasks
@peetucket peetucket merged commit e1b7b02 into master Sep 27, 2018
@peetucket peetucket deleted the mail_template branch September 27, 2018 21:23
@peetucket peetucket removed the review label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants