add progress logging to the discovery report jobs similar to pre-assembly jobs #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
add-logging-to-discovery-report
branch
from
883184a
to
2790488
Compare
peetucket
force-pushed
the
add-logging-to-discovery-report
branch
from
2790488
to
a376048
Compare
peetucket
force-pushed
the
add-logging-to-discovery-report
branch
from
a376048
to
b42f18d
Compare
jcoyne
requested changes
Jun 17, 2020
.rubocop.yml
Outdated
| @@ -60,6 +60,7 @@ RSpec/MultipleExpectations: | |||
| Max: 5 | |||
| Exclude: | |||
| - 'spec/features/*' | |||
| - 'spec/services/discovery_report_spec.rb' | |||
There was a problem hiding this comment.
Suggested change
| - 'spec/services/discovery_report_spec.rb' | |
| - 'spec/**/*_spec.rb' |
There was a problem hiding this comment.
Done, though this effectively just disables that cop I believe by ignoring any specs.
jcoyne
approved these changes
Jun 18, 2020
jcoyne
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
Long running discovery report jobs cannot be monitored to see if they are stuck or still running. This would add a running progress log that could be tailed to monitor progress.
fixes #693
How was this change tested?
once reviewed, can be deployed to stage and tested there with a discovery report job
Which documentation and/or configurations were updated?
none