Link to collection without requiring a second lookup #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
reviewed
May 28, 2024
| @@ -20,7 +20,7 @@ | |||
| <%= javascript_importmap_tags @embed_response.viewer.importmap if @embed_response.viewer.importmap %> | |||
| <%= stylesheet_link_tag @embed_response.viewer.stylesheet %> | |||
| <%= stylesheet_link_tag 'sul_icons.css' %> | |||
| <%= tag :link, rel: "up", href: Embed::Purl.find(@embed_response.request.purl_object.collections.first).purl_url if @embed_response && @embed_response.request.purl_object.collections.any? %> | |||
| <%= tag :link, rel: "up", href: @embed_response.request.purl_object.first_collection_url if @embed_response && @embed_response.request.purl_object.first_collection_url %> | |||
There was a problem hiding this comment.
If a Purl instance has no collections, won't Purl#first_collection_url return "#{Settings.purl_url}/#{nil}" (truthy)?
There was a problem hiding this comment.
This is now handled in the model. Thank you.
Fixes #2154 The link is only used for analytics, so it shouldn't matter if the collection is dark or not
jcoyne
force-pushed
the
avoid-unnecessary-load
branch
from
5c11f08
to
8d46846
Compare
mjgiarlo
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2154
The link is only used for analytics, so it shouldn't matter if the collection is dark or not