Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rake from 11.3.0 to 12.2.1 #416

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 13, 2017

Bumps rake from 11.3.0 to 12.2.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase?.

If you'd like to skip this version, you can just close this PR. If you have any feedback just mention @dependabot in the comments below.

@dazza-codes
Copy link
Contributor

dazza-codes commented Nov 13, 2017

Maybe rubocop rake task is not compatible with rake 12.x?

$ bundle exec rake ci
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00000001700890>
/home/travis/build/sul-dlss/sul_pub/vendor/bundle/ruby/2.4.0/gems/rubocop-0.37.2/lib/rubocop/rake_task.rb:24:in `initialize'
/home/travis/build/sul-dlss/sul_pub/Rakefile:27:in `new'
/home/travis/build/sul-dlss/sul_pub/Rakefile:27:in `block in <top (required)>'
/home/travis/build/sul-dlss/sul_pub/vendor/bundle/ruby/2.4.0/gems/rake-12.2.1/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.4.1/bin/bundle:23:in `load'
/home/travis/.rvm/gems/ruby-2.4.1/bin/bundle:23:in `<main>'
Tasks: TOP => ci => rubocop

Replicated this on my laptop using this branch. On my laptop, both of these work:

bundle exec rubocop
bundle exec rake

So, it's specific to the ci task, i.e.

task default: [:ci]

desc 'Continuous integration task run on travis'
task ci: [:rubocop, :spec]
$ bundle exec rake rubocop
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00561039bd7d20>
/data/src/dlss/cap/sul_pub/Rakefile:27:in `new'
/data/src/dlss/cap/sul_pub/Rakefile:27:in `block in <top (required)>'
/data/src/dlss/cap/sul_pub/.bundle/bin/bundle:104:in `load'
/data/src/dlss/cap/sul_pub/.bundle/bin/bundle:104:in `<main>'
Tasks: TOP => rubocop
(See full trace by running task with --trace)

This upgrade to rake 12.x could depend on upgrading rubocop, which depends on a change to dlss_cops, see

@dazza-codes
Copy link
Contributor

After sul-dlss-deprecated/dlss_cops#8 is released to rubygems, we could update the dlss_cops and get a later version of rubocop. This could unblock this upgrade to rake 12.x

@dependabot-preview
Copy link
Contributor Author

Superseded by #466.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rake-12.2.1 branch November 27, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant