Updated composer.json to support symfony 4 #106
Conversation
wachterjohannes
force-pushed
the
symfony-4-support
branch
from
f8fbc40
to
e50f1ba
Compare
wachterjohannes
changed the title
wachterjohannes
force-pushed
the
symfony-4-support
branch
4 times, most recently
from
1169a55
to
923cc94
Compare
|
@alexander-schranz the test fails also in develop so i think we should fix that first |
wachterjohannes
force-pushed
the
symfony-4-support
branch
from
923cc94
to
15646a4
Compare
wachterjohannes
force-pushed
the
symfony-4-support
branch
from
15646a4
to
8d9521e
Compare
|
@wachterjohannes you need to update phpunit see sulu/sulu#3931 and reimplement the 2.0 admin for blacklisting feature |
|
@alexander-schranz i have done the phpunit update and the admin is not part of this PR - but symfony is not rendering the |
|
@alexander-schranz csrf protection is not enabled by default: see https://symfony.com/doc/current/security/csrf.html Normally sulu does prepend this in the security bundle: https://github.com/sulu/sulu/blob/480347158175b1c37a808209fb947ffa2a2a0d38/src/Sulu/Bundle/SecurityBundle/DependencyInjection/SuluSecurityExtension.php#L74 but think we are now doing this only for admin context accidently, which we should move doing it always. But we should also prepend this in the community bundle. |
| "symfony/security-acl": "^2.8 || ^3.0", | ||
| "symfony/swiftmailer-bundle": "^2.6.4" | ||
| "massive/build-bundle": "^0.2 || ^0.3 || ^0.4", | ||
| "sulu/sulu": "dev-develop", |
There was a problem hiding this comment.
i will change this as soon the alpha 4 is tagged
There was a problem hiding this comment.
ok thought ^2.0@dev would install dev-develop but seems to install 2.0-alpha-4 😮
wachterjohannes
force-pushed
the
symfony-4-support
branch
from
5b34bf5
to
1719c7d
Compare
wachterjohannes
force-pushed
the
symfony-4-support
branch
from
1719c7d
to
2b17975
Compare
alexander-schranz
changed the title
What's in this PR?
Allows symfony 4 in composer.json