Add DimensionContentQueryEnhancer service #190

alexander-schranz · 2021-06-21T15:39:51Z

The DimensionContentQueryEnhancer will make it possible the Repository of a ContentRichEntity in our current case the Article. The DimensionContentQueryEnhancer provide all required filters like categories, tags, template keys which are used by smart content. Also it provide the logic how the select join work as they are very complex to select only the dimensions which are required to be performant. The current implementation is very imperformant as when a list is loaded all dimension content are loaded as separate queries and are not correctly joined.

coveralls · 2021-06-23T08:34:56Z

Pull Request Test Coverage Report for Build 1294915754

119 of 119 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 1291214054:	0.0%
Covered Lines:	2025
Relevant Lines:	2025

💛 - Coveralls

Content/Domain/Model/DimensionContentInterface.php

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php

niklasnatter · 2021-06-25T13:53:04Z

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php

+     * @param class-string<DimensionContentInterface> $dimensionContentClassName
+     * @param mixed[] $dimensionAttributes
+     */
+    public function enhanceDimensionContentSelect(


do you use this function in the SuluArticleBundle?
if not, i think i would keep the logic in the DimensionContentRepository for now.
if yes, i think i would call it addSelect/addEffectiveDimensionContentSelect 🙂

It will be used in the article bundle, but think I need first implement it here in the Example Bundle to also write tests for it.

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php

niklasnatter · 2021-07-07T13:18:35Z

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php

+    ): void {
+        $effectiveAttributes = $dimensionContentClassName::getEffectiveDimensionAttributes($dimensionAttributes);
+        $this->addSortBy($queryBuilder, $effectiveAttributes);
+        $queryBuilder->addCriteria($this->getAttributesCriteria('dimensionContent', $effectiveAttributes));


maybe we should pass a dimensionContentAlias as parameter? 🤔

There are many other joins so I would not introduce a parameter for the aliases here.

i think i would add a ALIAS_DIMENSION_CONTENT constant then? 🙂

I would not yet add any constant here for aliases.

niklasnatter · 2021-07-07T13:21:33Z

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php

+        $examples = $queryBuilder->getQuery()->getResult();
+
+        foreach ($examples as $example) {
+            yield $example;


is there an advantage of yielding the results here instead of returning an array? 🤔

method should be refractored to us toIterator method of doctrine just need to test it. The advantage is a performance as if correctly used only 1 object instance is in memory why looping over it.

Currently just used a custom Generator to make sure all works with a Generator.

alexander-schranz · 2021-09-14T17:12:14Z

@nnatter ready for review.

niklasnatter · 2021-09-20T15:49:53Z

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php

+        }
+
+        $effectiveAttributes = $dimensionContentClassName::getEffectiveDimensionAttributes($dimensionAttributes);
+        $this->addSortBy($queryBuilder, $effectiveAttributes);


i am not sure if i would expect this method to change my sorting. you want to sort this to return the most specific DimensionContent first, right?

this also means that calling the addSelects method will lead to multiple rows per entity, right?

Will remove this sorting. in the future maybe it make sense that we can sort specially for smart content by published date but that should be handled in a additional addSortBy method.

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php

Content/Infrastructure/Doctrine/DimensionContentRepository.php

niklasnatter · 2021-09-21T11:54:27Z

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php

+            );
+        }
+
+        $locale = $dimensionAttributes['locale'] ?? null;


i think $dimensionAttributes is not defined anywhere? wondering why phpstan is okay with this? 🙈

this is false, funny that the test doesn't cover this

did update it.

niklasnatter · 2021-09-21T11:55:16Z

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php

+
+        $contentFilters = [];
+        foreach ([
+            'locale',


this would be needed in every repository and makes it harder to extend things 😕

maybe we can just pass all $filters to the dimensionContentQueryEnhancer?

or we could add a prefix for filters that should be passed to the dimensionContentQueryEnhancer? eg dimensionContent.categoryIds

I'm fine currently to forward the filters directly to the enhancer

niklasnatter · 2021-09-21T11:58:20Z

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php

+                'dimensionContent'
+            );
+
+            $this->dimensionContentQueryEnhancer->addSelects(


this will lead to multiple rows for a single example like described in #190 (comment), right? 🤔

As discussed addSelect will just add the joined to relation and not create a new instance of the example object.

alexander-schranz · 2021-10-01T11:41:51Z

Content/Domain/Model/DimensionContentCollection.php

-    /**
-     * @var DimensionContentInterface|null
-     */
-    private $unlocalizedDimensionContent;


this are private variables which were just set but not used.

alexander-schranz · 2021-10-01T11:50:00Z

@nnatter Ready for rereview ;)

Content/Domain/Model/DimensionContentCollection.php

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch 3 times, most recently from 0ff0dca to 2c5dc16 Compare June 22, 2021 16:02

alexander-schranz mentioned this pull request Jun 22, 2021

Add experimental ArticleRepository and ArticleController sulu/SuluArticleBundle#583

Merged

45 tasks

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch 4 times, most recently from 26613be to 289d3d4 Compare June 23, 2021 08:33

niklasnatter reviewed Jun 23, 2021

View reviewed changes

Content/Domain/Model/DimensionContentInterface.php Show resolved Hide resolved

niklasnatter reviewed Jun 23, 2021

View reviewed changes

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php Outdated Show resolved Hide resolved

niklasnatter reviewed Jun 25, 2021

View reviewed changes

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch from ec5b56e to 9c07160 Compare June 28, 2021 12:09

niklasnatter reviewed Jul 7, 2021

View reviewed changes

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php Outdated Show resolved Hide resolved

niklasnatter reviewed Jul 7, 2021

View reviewed changes

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php Show resolved Hide resolved

niklasnatter reviewed Jul 7, 2021

View reviewed changes

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch from 9c07160 to 2e8fc42 Compare July 8, 2021 11:08

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch 2 times, most recently from 6a10002 to 7df8905 Compare September 14, 2021 09:25

alexander-schranz added 4 commits September 14, 2021 16:42

Add DimensionContentQueryEnhancer service

60e1c44

Fix DimensionContentQueryEnhancer

5698652

Fix php-cs

83ff72b

Add dimension content query enhancer

a820d3f

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch from c69b7f5 to a820d3f Compare September 14, 2021 15:38

Update dimension content query enhancer

5e0867b

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch from 65a8c70 to 5e0867b Compare September 14, 2021 16:49

Fix PHP CS

b95daf3

alexander-schranz added the DX Only affecting the end developer label Sep 14, 2021

alexander-schranz marked this pull request as ready for review September 14, 2021 17:02

alexander-schranz changed the title ~~WIP: Add DimensionContentQueryEnhancer service~~ Add DimensionContentQueryEnhancer service Sep 14, 2021

niklasnatter reviewed Sep 20, 2021

View reviewed changes

niklasnatter reviewed Sep 21, 2021

View reviewed changes

Content/Infrastructure/Doctrine/DimensionContentQueryEnhancer.php Outdated Show resolved Hide resolved

niklasnatter reviewed Sep 21, 2021

View reviewed changes

Content/Infrastructure/Doctrine/DimensionContentRepository.php Show resolved Hide resolved

niklasnatter reviewed Sep 21, 2021

View reviewed changes

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch 2 times, most recently from 94bb509 to dd1a227 Compare October 1, 2021 11:37

alexander-schranz commented Oct 1, 2021

View reviewed changes

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch from dd1a227 to 15c63ee Compare October 1, 2021 11:48

Adjustements for dimesion content query enhancer

d9497bd

alexander-schranz force-pushed the feature/dimension-content-query-enhancer branch from 15c63ee to d9497bd Compare October 1, 2021 11:49

alexander-schranz mentioned this pull request Oct 2, 2021

Add versioning to dimension content #202

Draft

7 tasks

niklasnatter reviewed Oct 4, 2021

View reviewed changes

Content/Domain/Model/DimensionContentCollection.php Outdated Show resolved Hide resolved

Update Content/Domain/Model/DimensionContentCollection.php

5e5ca63

niklasnatter reviewed Oct 4, 2021

View reviewed changes

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php Outdated Show resolved Hide resolved

Tests/Application/ExampleTestBundle/Repository/ExampleRepository.php Outdated Show resolved Hide resolved

Fix example repository select constants

dba3d13

niklasnatter merged commit 9fa38cb into sulu:0.x Oct 4, 2021

alexander-schranz mentioned this pull request Aug 8, 2024

ArticleBundle 3.0 without PHPCR and Elasticsearch sulu/SuluArticleBundle#690

Open

45 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DimensionContentQueryEnhancer service #190

Add DimensionContentQueryEnhancer service #190

alexander-schranz commented Jun 21, 2021 •

edited

Loading

coveralls commented Jun 23, 2021 •

edited

Loading

niklasnatter Jun 25, 2021

alexander-schranz Jun 25, 2021

niklasnatter Jul 7, 2021

alexander-schranz Jul 8, 2021

niklasnatter Sep 21, 2021

alexander-schranz Sep 21, 2021

niklasnatter Jul 7, 2021

alexander-schranz Jul 7, 2021 •

edited

Loading

alexander-schranz Jul 8, 2021

alexander-schranz commented Sep 14, 2021

niklasnatter Sep 20, 2021

niklasnatter Sep 20, 2021

alexander-schranz Sep 21, 2021

niklasnatter Sep 21, 2021

alexander-schranz Sep 21, 2021

alexander-schranz Oct 1, 2021

niklasnatter Sep 21, 2021

niklasnatter Sep 21, 2021

niklasnatter Sep 21, 2021

alexander-schranz Sep 21, 2021

niklasnatter Sep 21, 2021 •

edited

Loading

alexander-schranz Sep 21, 2021

alexander-schranz Oct 1, 2021

alexander-schranz commented Oct 1, 2021

Add DimensionContentQueryEnhancer service #190

Add DimensionContentQueryEnhancer service #190

Conversation

alexander-schranz commented Jun 21, 2021 • edited Loading

coveralls commented Jun 23, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1294915754

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-schranz Jul 7, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-schranz commented Sep 14, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niklasnatter Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexander-schranz commented Oct 1, 2021

alexander-schranz commented Jun 21, 2021 •

edited

Loading

coveralls commented Jun 23, 2021 •

edited

Loading

alexander-schranz Jul 7, 2021 •

edited

Loading

niklasnatter Sep 21, 2021 •

edited

Loading