Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ghost Locale Handling #212

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add Ghost Locale Handling #212

merged 1 commit into from
Oct 19, 2021

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Oct 14, 2021 •
edited
Loading

TODO

  • Show ghost title in list
  • Show ghost locale in list
  • Allow language switch in List
  • Allow language switch in Form
  • Show copy from locale overlay
  • Add DimensionContentMerger Test
  • Add Query Enhancer Test

Related Issue:

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Bundle label Oct 14, 2021
@alexander-schranz alexander-schranz force-pushed the feature/ghost-locale branch 5 times, most recently from 7c1d22f to cfc59d0 Compare October 14, 2021 18:28
@coveralls
Copy link

coveralls commented Oct 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1346553110

  • 32 of 32 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1340881271: 0.0%
Covered Lines: 2035
Relevant Lines: 2035
💛 - Coveralls

@alexander-schranz alexander-schranz force-pushed the feature/ghost-locale branch 14 times, most recently from 47393ef to 4ffbd5c Compare October 15, 2021 15:40
@alexander-schranz alexander-schranz marked this pull request as ready for review October 15, 2021 16:14
@alexander-schranz alexander-schranz changed the title Add ghost locale handling Add Ghost Locale Handling Oct 15, 2021
@alexander-schranz alexander-schranz mentioned this pull request Oct 15, 2021
Merged
45 tasks
@wachterjohannes wachterjohannes merged commit b88875b into sulu:0.x Oct 19, 2021
@alexander-schranz alexander-schranz mentioned this pull request Aug 8, 2024
Open
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wachterjohannes wachterjohannes wachterjohannes approved these changes

Assignees

@wachterjohannes wachterjohannes

@alexander-schranz alexander-schranz

Labels
Feature New functionality not yet included in Bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-schranz @coveralls @wachterjohannes