This repository has been archived by the owner on Dec 18, 2020. It is now read-only.
added translation and configuration #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
danrot
force-pushed
the
feature/collaboration
branch
from
493cccb
to
832574b
Compare
| @@ -21,9 +21,10 @@ public function registerBundles() | |||
| new Symfony\Bundle\MonologBundle\MonologBundle(), | |||
| new Symfony\Bundle\SwiftmailerBundle\SwiftmailerBundle(), | |||
| new Symfony\Bundle\AsseticBundle\AsseticBundle(), | |||
| new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(), | |||
| new Sulu\Bundle\CoreBundle\SuluCoreBundle(), | |||
There was a problem hiding this comment.
Had To move that one higher, in order to use the %sulu.cache_dir% container parameter in the DoctrineCacheBundle configuration. Would say it is a good idea anyway, since the SuluCoreBundle should initialize the most important stuff and make that available as soon as possible. /cc @chirimoya @wachterjohannes
danrot
force-pushed
the
feature/collaboration
branch
from
832574b
to
bd495b4
Compare
| collaboration: | ||
| enabled: true | ||
| entity_cache: doctrine_cache.providers.sulu_collaboration_entity | ||
| connection_cache: doctrine_cache.providers.sulu_collaboration_connection |
There was a problem hiding this comment.
are this service ids build by DoctrineCacheBundle seems to be very magic (: we should really think about including StashPHP
There was a problem hiding this comment.
Why magic? That's pretty clear to me. But still StashPHP might be a good idea.
danrot
force-pushed
the
feature/collaboration
branch
from
bd495b4
to
4a4aea1
Compare
danrot
force-pushed
the
feature/collaboration
branch
from
4a4aea1
to
b75965e
Compare
wachterjohannes
added a commit
that referenced
this pull request
Jan 29, 2016
added translation and configuration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
informations: