New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with php 5.5 #845

Merged
merged 6 commits into from Jul 16, 2018

Conversation

Projects
None yet
3 participants
@alexander-schranz
Member

alexander-schranz commented Feb 27, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Allow symfony 2.8 and check if web server bundle exists.

Why?

Fix the compatibility with php 5.5

Example Usage

php55 /usr/local/bin/composer install

@alexander-schranz alexander-schranz changed the title from Fix compatibility with php 5.5 to WIP: Fix compatibility with php 5.5 Feb 27, 2018

@alexander-schranz alexander-schranz changed the title from WIP: Fix compatibility with php 5.5 to Fix compatibility with php 5.5 Jun 28, 2018

@alexander-schranz

This comment has been minimized.

Show comment
Hide comment
@alexander-schranz

alexander-schranz Jun 28, 2018

Member

Thanks to @ilyabakhlin who did add the last puzzle to make the test run on 5.5 again.

Member

alexander-schranz commented Jun 28, 2018

Thanks to @ilyabakhlin who did add the last puzzle to make the test run on 5.5 again.

@danrot

This comment has been minimized.

Show comment
Hide comment
@danrot

danrot Jun 29, 2018

Member

The build is failing for some reason different than before 🙈 Can you investigate that? I'd say it should at least execute composer install correctly

Member

danrot commented Jun 29, 2018

The build is failing for some reason different than before 🙈 Can you investigate that? I'd say it should at least execute composer install correctly

@ilyabakhlin

This comment has been minimized.

Show comment
Hide comment
@ilyabakhlin

ilyabakhlin Jul 2, 2018

@alexander-schranz, the rebase has removed my changes, hahaha!

ilyabakhlin commented Jul 2, 2018

@alexander-schranz, the rebase has removed my changes, hahaha!

ilyabakhlin added some commits Jun 28, 2018

Fixing the PHP 5.5 Compatibility (#1)
* Improving the beforetests.sh script.

* Adding some arguments to the composer install execution.

* Adding an if statement for the project installation.
@alexander-schranz

This comment has been minimized.

Show comment
Hide comment
@alexander-schranz

alexander-schranz Jul 2, 2018

Member

@ilyabakhlin ups fixed it xD

Member

alexander-schranz commented Jul 2, 2018

@ilyabakhlin ups fixed it xD

@danrot danrot merged commit 6c2b906 into sulu:master Jul 16, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexander-schranz alexander-schranz deleted the alexander-schranz:hotfix/php-55-compatibility branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment