This repository has been archived by the owner on Dec 18, 2020. It is now read-only.
Fix compatibility with php 5.5 #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
hotfix/php-55-compatibility
branch
3 times, most recently
from
18ddb97
to
7fff19a
Compare
alexander-schranz
changed the title
alexander-schranz
changed the title
|
Thanks to @ilyabakhlin who did add the last puzzle to make the test run on 5.5 again. |
|
The build is failing for some reason different than before 🙈 Can you investigate that? I'd say it should at least execute |
alexander-schranz
force-pushed
the
hotfix/php-55-compatibility
branch
from
a0f1c80
to
8431efa
Compare
|
@alexander-schranz, the rebase has removed my changes, hahaha! |
added 2 commits
July 2, 2018 09:56
* Improving the beforetests.sh script. * Adding some arguments to the composer install execution. * Adding an if statement for the project installation.
|
@ilyabakhlin ups fixed it xD |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Allow symfony 2.8 and check if web server bundle exists.
Why?
Fix the compatibility with php 5.5
Example Usage