Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix media types configuration #4344

Merged
merged 7 commits into from
Mar 5, 2019
Merged

Fix media types configuration #4344

merged 7 commits into from
Mar 5, 2019

Conversation

markdehaan
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #4343
License MIT

What's in this PR?

Changed configuration tree builder in order to stop Sulu from crashing.

@alexander-schranz
Copy link
Member

@markdehaan Thank you for your pull request! Can I ask you which mimetypes you want to change in your application and why, just if its maybe something which is interesting for 2.0 to be changed.

@markdehaan
Copy link
Contributor Author

@alexander-schranz We were just experimenting with the config when we encountered this bug. For the moment there is no explicit need to change the mime types.

@alexander-schranz
Copy link
Member

@markdehaan can you rebase (update) your branch with the latest changes from master, then PrettyCI should not longer fail.

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Mar 1, 2019
@alexander-schranz alexander-schranz changed the title format manager types configuration cannot be changed Fix media types configuration Mar 1, 2019
@alexander-schranz
Copy link
Member

alexander-schranz commented Mar 1, 2019 •
edited
Loading

@markdehaan sorry bothering you again. Can you create a new * dev-master* section in the changelog we had a release yesterday 🙈 .

@markdehaan
Copy link
Contributor Author

@alexander-schranz "continuous-integration/styleci/pr" is waiting for status to be reported since friday...

@alexander-schranz
Copy link
Member

@markdehaan can be ignored aslong prettyci is green.
@danrot from my site its ok do you want to have also a look at it?

@danrot danrot merged commit 96a8297 into sulu:master Mar 5, 2019
@danrot
Copy link
Contributor

danrot commented Mar 5, 2019

@markdehaan Thank you! 🙂

@markdehaan markdehaan deleted the bugfix/format-manager-types-configuration branch October 17, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Milestone
Release 1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@markdehaan @alexander-schranz @danrot