Show error when deleting parent account #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO there is currently only one issue: When the error message is shown, deletion cannot be continued, but the dialog still shows two buttons: "Ok" and "Cancel". I think one of both should be gone, but I am not completely sure which one. @chirimoya Do you have any idea? |
|
|
||
| return $query->getResult(); | ||
| } catch (NoResultException $ex) { | ||
| return null; |
There was a problem hiding this comment.
i think i would expect an empty array in this case
There was a problem hiding this comment.
You are right, that's better 🙂 Done.
|
|
||
| ### DeleteToolbarAction with conflict | ||
|
|
||
| The `DeleteToolbarAction` asks for confirmation if e.g. a page that is being tried to deleted is linked on other pages. |
There was a problem hiding this comment.
not sure if being tried to deleted is correct. but dont have a better suggestion and i guess people will understand it anyway 🙂
danrot
force-pushed
the
hotfix/parent-account-deletion
branch
from
fc897d9
to
9edd378
Compare
niklasnatter
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR introduces an error message when an account which is the parent of another account is trying to be deleted.
Why?
Because we don't want to delete the child accounts when a parent account is deleted. What should happen instead is not completely clear, and this way the user can decide how to resolve this conflict.
And it is the same behavior as in Sulu 1.6.
To Do