Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templating error #4836

Merged

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Oct 21, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets ---
Related issues/PRs ---
License MIT
Documentation PR ---

What's in this PR?

The FOSRest bundle removed a dependency (symfony/templating), which we were still prepending a configuration. We have to add the dependency on our own now, because otherwise Symfony will complain that this configuration does not exist.

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Oct 21, 2019
@alexander-schranz alexander-schranz added this to the Release 2.0 milestone Oct 21, 2019
@alexander-schranz alexander-schranz merged commit 4764847 into sulu:release/2.0 Oct 21, 2019
@danrot danrot deleted the hotfix/symfony-templating branch October 21, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants