Register route field-type only on first login #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
the
Bug
alexander-schranz
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Looks good from my view. Still would like if @danrot could have a look at it if this is the correct way to handle it.
niklasnatter
force-pushed
the
bugfix/successive-login
branch
from
c9bf188
to
12a2a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR adjusts the
index.jsof theRouteBundleto register theroutefield-type one on the first login.Why?
Because otherwise, this will throw an error if somebody logs in, logs out and logs in again without reloading the application.
Reproducing the Problem