Fix default-values for multiple-select in blocks #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prokyonn
force-pushed
the
bugfix/block-default-values
branch
from
869cdd8
to
88b4bfa
Compare
alexander-schranz
added
the
Bug
Prokyonn
force-pushed
the
bugfix/block-default-values
branch
from
71c1d7a
to
8f46ccc
Compare
Prokyonn
force-pushed
the
bugfix/block-default-values
branch
from
b8d0d32
to
86fe6af
Compare
|
Reminder: Check if we need to do something similar for the |
Prokyonn
force-pushed
the
bugfix/block-default-values
branch
from
86fe6af
to
64405a6
Compare
danrot
suggested changes
Nov 2, 2020
There was a problem hiding this comment.
I think that's a better solution than the two I came up with 👍
So I am generally fine with that, still added a few minor issues resp. questions for better understanding.
src/Sulu/Bundle/AdminBundle/Resources/js/containers/FieldBlocks/FieldBlocks.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/containers/FieldBlocks/FieldBlocks.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/containers/FieldBlocks/FieldBlocks.js
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/containers/FieldBlocks/tests/FieldBlocks.test.js
Outdated
Show resolved
Hide resolved
src/Sulu/Bundle/AdminBundle/Resources/js/containers/FieldBlocks/tests/FieldBlocks.test.js
Show resolved
Hide resolved
Prokyonn
force-pushed
the
bugfix/block-default-values
branch
from
199d4b3
to
f500c94
Compare
danrot
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes the default-values in blocks. See #4987
An additional
valueattribute is introduced to save the state of thevalue. Previously thevaluewas saved in the properties (this.props), but the properties are updated after thedefault-valueis set for the nextsingle_select, thus thevalueis not up to date during the rendering of the other components.Now the new
valueattribute is manually updated before the next component is rendered.Why?
The default value was only working for the last component.
Todo