Replace swiftmailer with symfony mailer #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/replace-swiftmailer-with-symfony-mailer
branch
from
e1b82a8
to
81271db
Compare
alexander-schranz
force-pushed
the
feature/replace-swiftmailer-with-symfony-mailer
branch
from
4a48789
to
f060dce
Compare
alexander-schranz
force-pushed
the
feature/replace-swiftmailer-with-symfony-mailer
branch
from
2e828b3
to
3c72465
Compare
alexander-schranz
force-pushed
the
feature/replace-swiftmailer-with-symfony-mailer
branch
from
3c72465
to
84211ae
Compare
Comment on lines
+29
to
+32
| # SwiftMailer was removed and con not be analyzed by phpstan anymore | ||
| - %currentWorkingDirectory%/src/Sulu/Bundle/SecurityBundle/Tests/Functional/Controller/LegacyResettingControllerTest.php | ||
| - %currentWorkingDirectory%/src/Sulu/Bundle/MarkupBundle/Listener/SwiftMailerListener.php | ||
| - %currentWorkingDirectory%/src/Sulu/Bundle/MarkupBundle/Tests/Unit/Listener/SwiftMailerListenerTest.php |
There was a problem hiding this comment.
PHPStan can not analyze this as SwiftMailer is not installed here for Symfony 6 compatibility:
wachterjohannes
approved these changes
Apr 25, 2022
84 tasks
alexander-schranz
deleted the
feature/replace-swiftmailer-with-symfony-mailer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Replace swiftmailer with symfony mailer.
Why?
To support symfony 6 in the future.
To Do