Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doctrine/persistence 3.0 and doctrine/collections 2.0 #6643

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jun 10, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #7134, #7027, #7184, #7198, #7235
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Allow doctrine/persistence 3.0

Why?

Avoid outdated doctrine/persistence dependency.

Current outdated list:

doctrine/cache                      1.13.0 2.2.0  PHP Doctrine Cache library is a popular cache implementation th...
doctrine/persistence                2.5.3  3.0.2  The Doctrine Persistence project is a set of shared interfaces ...
guzzlehttp/psr7                     1.8.5  2.3.0  PSR-7 message implementation that also provides common utility ...
league/flysystem                    1.1.9  3.0.20 Filesystem abstraction: Many filesystems, one API.
league/flysystem-aws-s3-v3          1.0.29 3.0.13 Flysystem adapter for the AWS S3 SDK v3.x
league/flysystem-azure-blob-storage 1.0.0  3.0.9
monolog/monolog                     2.7.0  3.1.0  Sends your logs to files, sockets, inboxes, databases and vario...

TODO

@alexander-schranz alexander-schranz added the DX Affecting the end developer label Jun 10, 2022
@alexander-schranz alexander-schranz changed the base branch from 2.5 to 2.6 October 17, 2023 20:50
@alexander-schranz alexander-schranz marked this pull request as ready for review October 17, 2023 20:52
@stollr
Copy link
Contributor

stollr commented Dec 5, 2023

@alexander-schranz Can't we use EntityManagerInterface::getReference as a replacement? At the end it is doing something similar.

$newWebspace = $this->getEntityManager()->merge($webspace); // should be the same as the following

$newWebspace = $this->getEntityManager()->getReference(Webspace::class, $webspace->getId());

@alexander-schranz
Copy link
Member Author

@stollr moving discussion to: #7198

@alexander-schranz
Copy link
Member Author

As @redjanym refactored the last usage of merge to persist in #7235 🎉

We are now able to upgrade doctrine/persistence package.

@alexander-schranz alexander-schranz changed the title Allow doctrine/persistence 3.0 Allow doctrine/persistence 3.0 and doctrine/collection 2.0 Feb 5, 2024
@alexander-schranz alexander-schranz changed the title Allow doctrine/persistence 3.0 and doctrine/collection 2.0 Allow doctrine/persistence 3.0 and doctrine/collections 2.0 Feb 5, 2024
@alexander-schranz
Copy link
Member Author

alexander-schranz commented Feb 5, 2024

We currently can only enable persistence 3 support in 2.6 because some required changes are only merged into 2.6 yet:

and

I'm not sure if we should really backmerge that 2 pull requests or not for

They (#7027, #7134) contains some major changes, and smaller bc breaks in changed constants 🤔 .

/cc @chirimoya @wachterjohannes @Prokyonn. What do you think?

@alexander-schranz alexander-schranz changed the base branch from 2.5 to 2.6 February 5, 2024 16:11
@stollr
Copy link
Contributor

stollr commented Feb 5, 2024

@alexander-schranz What is preventing 2.6 Form being released?

@alexander-schranz
Copy link
Member Author

@stollr the planned featureset for 2.6 is not yet finished: https://github.com/sulu/sulu/milestone/26

@alexander-schranz alexander-schranz merged commit 8c82c7d into sulu:2.6 Feb 5, 2024
@alexander-schranz alexander-schranz mentioned this pull request May 10, 2024
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants