-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow doctrine/persistence 3.0 and doctrine/collections 2.0 #6643
Allow doctrine/persistence 3.0 and doctrine/collections 2.0 #6643
Conversation
216146d
to
260f1a9
Compare
260f1a9
to
072363e
Compare
@alexander-schranz Can't we use $newWebspace = $this->getEntityManager()->merge($webspace); // should be the same as the following
$newWebspace = $this->getEntityManager()->getReference(Webspace::class, $webspace->getId()); |
4817c79
to
a447285
Compare
a447285
to
57be3b3
Compare
We currently can only enable persistence 3 support in and I'm not sure if we should really backmerge that 2 pull requests or not for They (#7027, #7134) contains some major changes, and smaller bc breaks in changed constants 🤔 . /cc @chirimoya @wachterjohannes @Prokyonn. What do you think? |
57be3b3
to
7641e2d
Compare
@alexander-schranz What is preventing 2.6 Form being released? |
@stollr the planned featureset for 2.6 is not yet finished: https://github.com/sulu/sulu/milestone/26 |
What's in this PR?
Allow doctrine/persistence 3.0
Why?
Avoid outdated doctrine/persistence dependency.
Current outdated list:
TODO
EntityManagerInterface::merge
see phpstan issues