-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 7 versions of packages #7156
Allow Symfony 7 versions of packages #7156
Conversation
a50555c
to
959221e
Compare
1a37629
to
5e05f90
Compare
src/Sulu/Bundle/SecurityBundle/Security/AuthenticationEntryPoint.php
Outdated
Show resolved
Hide resolved
5e05f90
to
5428ea8
Compare
f6eeb72
to
9266bf7
Compare
9266bf7
to
da6047b
Compare
420874b
to
ce61d52
Compare
ce61d52
to
6de3d21
Compare
baf143e
to
1ffaf98
Compare
f33216d
to
6ff4b4d
Compare
f95798c
to
3eb0d3f
Compare
083986e
to
5f15777
Compare
78188be
to
1c3e4cd
Compare
1c3e4cd
to
89351bf
Compare
3028f15
to
841f94c
Compare
841f94c
to
9af2f2c
Compare
Tests seems to run now. The next step is to wait until jackalope/jackalope-doctrine-dbal#447 is merged. When that is merged we can merge sulu/skeleton#245 and as a next part bring our skeleton to Symfony 7. Thx @mamazu, @TheCadien and all other contributers and package maintainers that did make this possible. That is required that we can test on prod env the new versions of FOSHttpCache and FOSHttpCache After that all dependencies are then compatible we can then merge this one and merge then the Skeleton update to Symfony 7. The only thing we need to tackle to make
via a |
d3c06fd
to
d2de5f7
Compare
d00c263
to
1be612d
Compare
1be612d
to
4dfbb66
Compare
0d00c42
to
60808e6
Compare
60808e6
to
ce29c43
Compare
ce29c43
to
4fff931
Compare
What's in this PR?
Allow Symfony 7 versions of packages.
Why?
The hardest part in Sulu 1.6 -> 2.0 was that it was not only a Sulu upgrade but also a Symfony upgrade (3.4 -> 4.4). We should avoid this when we go from 2.x -> 3.0 so we should sure the last version of 2.x will be compatible with Symfony 7, this would make upgrades a lot easier as Sulu projects can first upgrade PHP, then Symfony and then jump to the next Sulu version.
TODOS
Symfony 6.4 errors
Testing PHP Fatal error: Declaration of Symfony\Bridge\Doctrine\Validator\DoctrineInitializer::initialize(object $object) must be compatible with Symfony\Component\Validator\ObjectInitializerInterface::initialize(object $object): void in /home/runner/work/sulu/sulu/vendor/symfony/doctrine-bridge/Validator/DoctrineInitializer.php on line 34
( Conflict symfony/validator 7.0 in symfony/doctrine-bridge 6.3 symfony/symfony#51630 )PHP Fatal error: Declaration of Sulu\Bundle\SecurityBundle\Security\AuthenticationEntryPoint::start(Symfony\Component\HttpFoundation\Request $request, ?Symfony\Component\Security\Core\Exception\AuthenticationException $authException = null) must be compatible with Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface::start(Symfony\Component\HttpFoundation\Request $request, ?Symfony\Component\Security\Core\Exception\AuthenticationException $authException = null): Symfony\Component\HttpFoundation\Response in /home/runner/work/sulu/sulu/src/Sulu/Bundle/SecurityBundle/Security/AuthenticationEntryPoint.php on line 25
Dependencies
Before we can test sulu against 7.0 we need to tackle the following external dependencies to be compatible with Symfony 7:
Our projects Statuses:
#7413