Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 versions of packages #7156

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Sep 11, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #
Related issues/PRs part of #7413
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Allow Symfony 7 versions of packages.

Why?

The hardest part in Sulu 1.6 -> 2.0 was that it was not only a Sulu upgrade but also a Symfony upgrade (3.4 -> 4.4). We should avoid this when we go from 2.x -> 3.0 so we should sure the last version of 2.x will be compatible with Symfony 7, this would make upgrades a lot easier as Sulu projects can first upgrade PHP, then Symfony and then jump to the next Sulu version.

TODOS

Symfony 6.4 errors

Dependencies

Before we can test sulu against 7.0 we need to tackle the following external dependencies to be compatible with Symfony 7:

Our projects Statuses:

#7413

@alexander-schranz alexander-schranz added Feature New functionality not yet included in Sulu DX Affecting the end developer labels Sep 11, 2023
@alexander-schranz alexander-schranz force-pushed the feature/symfony-7-support branch 2 times, most recently from a50555c to 959221e Compare September 16, 2023 10:09
composer.json Outdated Show resolved Hide resolved
@alexander-schranz
Copy link
Member Author

alexander-schranz commented May 6, 2024

Tests seems to run now. The next step is to wait until jackalope/jackalope-doctrine-dbal#447 is merged. When that is merged we can merge sulu/skeleton#245 and as a next part bring our skeleton to Symfony 7. Thx @mamazu, @TheCadien and all other contributers and package maintainers that did make this possible.

That is required that we can test on prod env the new versions of FOSHttpCache and FOSHttpCache 3.x@dev branches and give @dbu feedback if all works like expected. If that works @dbu can tag the last required dependencies for Symfony 7 compatibility.

After that all dependencies are then compatible we can then merge this one and merge then the Skeleton update to Symfony 7.

The only thing we need to tackle to make lowest here green is to configure:

security:
    enable_authenticator_manager: true

via a security.php dependently if we use Symfony 5.4. For Symfony 6 true is default and for Symfony 7 the config does not exists.

@alexander-schranz alexander-schranz marked this pull request as ready for review June 27, 2024 13:08
@alexander-schranz alexander-schranz merged commit c60927b into sulu:2.6 Jun 27, 2024
8 checks passed
@alexander-schranz alexander-schranz deleted the feature/symfony-7-support branch June 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants