-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating using the WebspaceManger
for getting webspaces
#7222
Open
mamazu
wants to merge
28
commits into
sulu:2.6
Choose a base branch
from
mamazu:deprecations_for_webspaces
base: 2.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2cc4d1a
to
63ec9ac
Compare
mamazu
commented
Dec 3, 2023
Comment on lines
+116
to
+117
private $key = null, | ||
private $name = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically passing null to those parameters will be also removed in 3.0.
63ec9ac
to
ebb349d
Compare
ebb349d
to
434d35b
Compare
WebspaceManger
for getting webspaces
7ef9f3a
to
6c04a4e
Compare
95376b1
to
5bf3fce
Compare
5bf3fce
to
11ff57e
Compare
d2d1fe0
to
f984021
Compare
@alexander-schranz Can you have a look at this and merge if possible? |
24eacf9
to
1608c68
Compare
f6a4853
to
2735eb8
Compare
cfc7584
to
5780b1c
Compare
09b2173
to
98cb783
Compare
117bd49
to
e102cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DX
Affecting the end developer
Technical Debt
Impacts code quality, no or just small impact on end developers and users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
WebspaceCollection
it's own service.WebspaceManager
Why?
We want to split those huge services up. That way we reduce the amount of dependencies a class has.
Example Usage
OLD:
NEW:
To Do