Make EnvironmentTest for Webspace more explicit #7437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
better_environment_test
branch
2 times, most recently
from
729f25f
to
3071338
Compare
mamazu
changed the title
EnvironmentTest more explicit
|
@mamazu can you rebase this to 2.5? |
mamazu
force-pushed
the
better_environment_test
branch
from
3071338
to
d3359ac
Compare
|
Done |
|
@alexander-schranz I think this is ready for merging now. |
mamazu
changed the title
EnvironmentTest more explicitEnvironmentTest more explicit
alexander-schranz
approved these changes
Jun 19, 2024
alexander-schranz
changed the title
EnvironmentTest more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Making the
EnvironmentTestmore explicit on what it does.Why?
When fixing the tests for the Webspace configuration migration I noticed that the second parameter of the Url wasn't used in this test. It turns out that it is overriden by the environment configuration. However, the type of the environment config is set after the url is added so the
environmentproperty in the expected result is empty (which should not happen). Seeing that the type is an essential property of the environment and should be configured in the constructor (see #7222 for that) We should move the setter call (that is part of the object setup) infront of theaddUrlcall.