-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare compatibility to Symfony 7 #7347
Merged
alexander-schranz
merged 22 commits into
sulu:2.6
from
alexander-schranz:enhancement/symfony-7-bc-breaks
Apr 9, 2024
Merged
Prepare compatibility to Symfony 7 #7347
alexander-schranz
merged 22 commits into
sulu:2.6
from
alexander-schranz:enhancement/symfony-7-bc-breaks
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 tasks
alexander-schranz
force-pushed
the
enhancement/symfony-7-bc-breaks
branch
from
April 5, 2024 15:43
0cb3158
to
e694218
Compare
alexander-schranz
force-pushed
the
enhancement/symfony-7-bc-breaks
branch
from
April 8, 2024 12:21
fa40435
to
021c315
Compare
alexander-schranz
force-pushed
the
enhancement/symfony-7-bc-breaks
branch
from
April 8, 2024 12:26
021c315
to
a5bfdb8
Compare
Prokyonn
approved these changes
Apr 9, 2024
Co-authored-by: Prokyonn <daniel.mathis@sector8.eu>
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Prepare compatibility to Symfony 7.
Why?
As discussed we will already cherry pick the required changes into 2.6 to prepare as much as possible for Symfony 7 compatibility.
Cherry pick bc breaks from #7156
Most of them should effect no projects so we are fine to add the return types as I don't think a lot of projects ever did come into contact with this more internal services.
To Do