Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare compatibility to Symfony 7 #7347

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Apr 5, 2024

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets fixes #
Related issues/PRs #7156
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Prepare compatibility to Symfony 7.

Why?

As discussed we will already cherry pick the required changes into 2.6 to prepare as much as possible for Symfony 7 compatibility.

Cherry pick bc breaks from #7156

Most of them should effect no projects so we are fine to add the return types as I don't think a lot of projects ever did come into contact with this more internal services.

To Do

  • Add breaking changes to UPGRADE.md

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Apr 5, 2024
@alexander-schranz alexander-schranz marked this pull request as ready for review April 5, 2024 15:42
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
Co-authored-by: Prokyonn <daniel.mathis@sector8.eu>
@alexander-schranz alexander-schranz merged commit 0b71912 into sulu:2.6 Apr 9, 2024
8 checks passed
@alexander-schranz alexander-schranz deleted the enhancement/symfony-7-bc-breaks branch April 9, 2024 13:06
@alexander-schranz alexander-schranz mentioned this pull request May 10, 2024
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants