Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor doctrine.event_subscriber to doctrine.event_listener for Symfony 7 compatibility #7374

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Refactor doctrine.event_subscriber to doctrine.event_listener for Symfony 7 compatibility #7374

merged 9 commits into from
Apr 22, 2024

Conversation

TheCadien
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets fixes #7156
License MIT
Documentation PR sulu/sulu-docs#

@TheCadien TheCadien changed the title Rename doctrine.event_subscriber to doctrine.event_listener WIP: Rename doctrine.event_subscriber to doctrine.event_listener Apr 22, 2024
@alexander-schranz
Copy link
Member

@TheCadien Please rebase to contain only the commits changing the event subscribers to event listeners.

alexander-schranz
alexander-schranz requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@alexander-schranz alexander-schranz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bc reasons I would keep all class names at current state.

And some of the tags are still missing the event definitions.

...Sulu/Bundle/ActivityBundle/Infrastructure/Doctrine/Listener/DomainEventCollectorListener.php Outdated Show resolved Hide resolved
src/Sulu/Bundle/PersistenceBundle/Resources/config/services.xml Outdated Show resolved Hide resolved
src/Sulu/Bundle/PersistenceBundle/Resources/config/services.xml Outdated Show resolved Hide resolved
@TheCadien
Copy link
Member Author

@alexander-schranz done

@alexander-schranz alexander-schranz changed the title WIP: Rename doctrine.event_subscriber to doctrine.event_listener Move doctrine.event_subscriber to doctrine.event_listener for Symfony 7 compatibility Apr 22, 2024
@alexander-schranz alexander-schranz changed the title Move doctrine.event_subscriber to doctrine.event_listener for Symfony 7 compatibility Refactor doctrine.event_subscriber to doctrine.event_listener for Symfony 7 compatibility Apr 22, 2024
@alexander-schranz alexander-schranz added the DX Affecting the end developer label Apr 22, 2024
@alexander-schranz alexander-schranz enabled auto-merge (squash) April 22, 2024 17:01
@alexander-schranz alexander-schranz merged commit 7a1e8fa into sulu:2.6 Apr 22, 2024
8 checks passed
@TheCadien TheCadien deleted the feature/symfony-7-support branch April 22, 2024 17:17
@alexander-schranz alexander-schranz mentioned this pull request Apr 22, 2024
Draft
76 tasks
@alexander-schranz
Copy link
Member

@TheCadien Thank you!

@alexander-schranz alexander-schranz mentioned this pull request May 10, 2024
Open
95 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

Assignees
No one assigned
Labels
DX Affecting the end developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheCadien @alexander-schranz