Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ParameterBag to HeaderBag in Core Tests #7390

Merged
merged 4 commits into from May 3, 2024

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented May 3, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs #7156 #7382
License MIT
Documentation PR -

What's in this PR?

Using the HeaderBag instead of the generic bag.

Why?

Symfony 7 🎉

@alexander-schranz
Copy link
Member

@mamazu Thx, Can we rebase this to 2.5 as we targetted also for the #7382 changes 2.5.

@alexander-schranz alexander-schranz added the DX Affecting the end developer label May 3, 2024
@alexander-schranz alexander-schranz changed the title Using the HeaderBag for header infos Refactor ParameterBag in HeaderBag in Core Tests May 3, 2024
@alexander-schranz alexander-schranz changed the title Refactor ParameterBag in HeaderBag in Core Tests Refactor ParameterBag to HeaderBag in Core Tests May 3, 2024
@mamazu mamazu changed the base branch from 2.6 to 2.5 May 3, 2024 09:56
@mamazu mamazu closed this May 3, 2024
@mamazu mamazu reopened this May 3, 2024
@alexander-schranz alexander-schranz merged commit 9d9cc87 into sulu:2.5 May 3, 2024
7 of 8 checks passed
@mamazu mamazu deleted the header_bag branch May 3, 2024 11:34
@alexander-schranz
Copy link
Member

@mamazu Thank you!

@alexander-schranz alexander-schranz mentioned this pull request May 10, 2024
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Affecting the end developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants