New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ParameterBag to HeaderBag in Core Tests #7390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Sulu/Bundle/WebsiteBundle/Tests/Unit/EventListener/AppendAnalyticsListenerTest.php
Outdated
Show resolved
Hide resolved
alexander-schranz
approved these changes
May 3, 2024
76 tasks
alexander-schranz
changed the title
Using the HeaderBag for header infos
Refactor ParameterBag in HeaderBag in Core Tests
May 3, 2024
alexander-schranz
changed the title
Refactor ParameterBag in HeaderBag in Core Tests
Refactor ParameterBag to HeaderBag in Core Tests
May 3, 2024
alexander-schranz
requested changes
May 3, 2024
src/Sulu/Bundle/WebsiteBundle/Tests/Unit/EventListener/AppendAnalyticsListenerTest.php
Outdated
Show resolved
Hide resolved
…nalyticsListenerTest.php
alexander-schranz
approved these changes
May 3, 2024
@mamazu Thank you! |
92 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Using the
HeaderBag
instead of the generic bag.Why?
Symfony 7 🎉