Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdToggleBookmarks works differently with F12 and when shortcut assigned #2832

Closed
selfmadebuba opened this issue Jul 27, 2022 · 0 comments
Closed

Comments

@selfmadebuba
Copy link

selfmadebuba commented Jul 27, 2022

Sumatra 3.4.6 release

CmdToggleBookmarks when CUSTOM shortcut is assigned and used works incorrectly:

  • opens and focuses bookmark window (it's possible to use cursor UP/DOWN on bookmark list)
  • after another F12 it DOES NOT UNFOCUS bookmark window and it's NOT CLOSING bookmarks properly
    (basically it's not a toggle in this case)

CmdToggleBookmarks when using default F12: (here it works properly)

  • opens and focuses bookmark window (it's possible to use cursor UP/DOWN on bookmark list)
  • on subsequent F12 it UNFOCUSES bookmark window and close it properly
    (it's a toggle in this case)

Solution
Sumatra should scan for shortcuts and custom hotkeys inside bookmarks when its tab/window is in focus
(excluding special keys used in this window like cursors and enter etc)

@kjk kjk changed the title Error] CmdToggleBookmarks works differently with F12 and when shortcut assigned CmdToggleBookmarks works differently with F12 and when shortcut assigned Sep 25, 2022
@kjk kjk closed this as completed in 03be423 Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant