Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Link to Image #226

Closed
setuun opened this issue Feb 7, 2014 · 42 comments
Closed

Set Link to Image #226

setuun opened this issue Feb 7, 2014 · 42 comments

Comments

@setuun
Copy link

setuun commented Feb 7, 2014

Hi again,

please, can you fix the Problem of Imagelinking? It is not possible to set links to an image.
Maybe, you can integration a button like the 100%,50%,25% one for an imagelink.

Thank you
Simon

@hackerwins hackerwins self-assigned this Feb 9, 2014
@hackerwins hackerwins added this to the v0.6.0 milestone Feb 9, 2014
@hackerwins hackerwins removed this from the v0.6.0 milestone Apr 26, 2014
@stefantalen
Copy link

+1

@ghost
Copy link

ghost commented Jun 13, 2014

👍 I was thinking something similar, and was even thinking of the possibility of being able to add custom data attributes and classes, so links can either be restyled or assigned for different actions, for eg, being able to have an image link or ajax type link open in fancybox or other similar addon.

@hackerwins hackerwins removed their assignment Jul 25, 2014
@rubenppeters
Copy link

It would be great if adding a link to an image would be possible. Like Simon said: a button like 100%, 50%, 25% would be perfect.

@acmitch
Copy link

acmitch commented Sep 9, 2014

+1 This needs to happen!

@dmlb
Copy link

dmlb commented Sep 9, 2014

+1

@josephjobys
Copy link

I am also in need for the same thing, a button for image link like 100%, 50%. It would be great if its implemented.

@lqez
Copy link
Member

lqez commented Nov 25, 2014

There was a PR #594 for this issue.
I'm waiting for @simonwillcock's implementation.

@BrianGreenhill
Copy link

+1

@angelogeminiani
Copy link

+1

@hackerwins
Copy link
Member

There are two pull requests(#754, #858) for image link. I thought We have to choose one.

@hackerwins hackerwins self-assigned this Oct 26, 2015
@angelogeminiani
Copy link

#858

1 similar comment
@feryardiant
Copy link
Contributor

#858

@Repox
Copy link

Repox commented Nov 12, 2015

Could someone make a decision and merge this?

@bjornoss
Copy link

+1

@hackerwins hackerwins removed their assignment Dec 3, 2015
@CG22
Copy link

CG22 commented Apr 6, 2016

+1

JoniJnm pushed a commit to bebeeteam/summernote that referenced this issue Apr 11, 2016
Changes:
* Image popover shows two new buttons: edit link and remove link
* Link dialog hides link text if an image was selected
* Prevents show link popover when an image has a link

To enhance:
* Only show remove link button when image has link
JoniJnm pushed a commit to bebeeteam/summernote that referenced this issue Apr 12, 2016
Changes:
* Image popover shows two new buttons: edit link and remove link
* Link dialog hides link text if an image was selected
* Prevents show link popover when an image has a link

TODO:
* Only show remove link button when image has link
JoniJnm pushed a commit to bebeeteam/summernote that referenced this issue Apr 25, 2016
Changes:
* Image popover shows two new buttons: edit link and remove link
* Link dialog hides link text if an image was selected
* Prevents show link popover when an image has a link

TODO:
* Only show remove link button when image has link
@medslt
Copy link

medslt commented Oct 24, 2016

+1

2 similar comments
@norbertledu
Copy link

+1

@ildarnm
Copy link

ildarnm commented Dec 7, 2016

+1

@Repox
Copy link

Repox commented Dec 7, 2016

This is almost two years old. It's ridiculous. I found an alternative solution.

@dankmitchell
Copy link

+1

1 similar comment
@jiteshgolecha
Copy link

+1

@geraldus
Copy link

Summernote is very cool. I can't believe this issue is not resolved yet!

@silviotroia
Copy link

+1

2 similar comments
@arvinwebavance
Copy link

+1

@nudgetman
Copy link

+1

@iSOOPS
Copy link

iSOOPS commented Nov 9, 2017

it function set link to image have implementation ? how and where the code?@hackerwins

@DiemenDesign
Copy link
Member

@iSOOPS
Copy link

iSOOPS commented Nov 9, 2017

@DiemenDesign
I creat a tools button for set link to image,becuse in my function need to choose a url but enter, have any way to add a link to image?even edit basic html code.

@DiemenDesign
Copy link
Member

Try the plugin, it does exactly what you need, as well as adding other attributes

@iSOOPS
Copy link

iSOOPS commented Nov 9, 2017

@DiemenDesign
i creat a button on popover and how can i get the click dom on button callback function?
by the way ,i creat a issue on summernote-image-attributes....

@lqez
Copy link
Member

lqez commented Nov 15, 2017

@DiemenDesign How about to make your plugin as a default feature? Could you make a PR for this? (And I invited you to the team)

@DiemenDesign
Copy link
Member

I could certainly look into this. And awesome, thank you, I just hope I live up to expectation.

@lqez
Copy link
Member

lqez commented Nov 16, 2017

@DiemenDesign Thank you. And please let me know your email address for inivitation. Please send me a mail to ez.amiryo at gmail dot com.

@DiemenDesign
Copy link
Member

@lqez email sent. Thank you for the confidence in me to join your team. I look forward to doing what I can to help make Summernote great.

@lqez
Copy link
Member

lqez commented Nov 16, 2017

Thank you all!

@lqez
Copy link
Member

lqez commented Jun 4, 2018

Please use https://github.com/DiemenDesign/summernote-image-attributes for this. Thanks.

@lqez lqez closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests